mac: Fix a history swiper bug where the shield wouldn't disappear.

chrome/browser/ui/cocoa/history_overlay_controller.mm

Index: chrome/browser/ui/cocoa/history_overlay_controller.mm
diff --git a/chrome/browser/ui/cocoa/history_overlay_controller.mm b/chrome/browser/ui/cocoa/history_overlay_controller.mm
index 53e879215296ca0c1dcae20dcccdc6ad149b5b7f..83ee32ce04d6fc052bde2a6eeed87a8c8a9ceb14 100644
--- a/chrome/browser/ui/cocoa/history_overlay_controller.mm
+++ b/chrome/browser/ui/cocoa/history_overlay_controller.mm
@@ -89,13 +89,6 @@ const CGFloat kShieldHeightCompletionAdjust = 10;
   return self;
 }
 
-- (void)dealloc {
-  [[BrowserWindowController
-      browserWindowControllerForView:[self view]] onOverlappedViewHidden];
-  [self.view removeFromSuperview];
-  [super dealloc];
-}

[Nico, 2013/12/27 23:56:13]

This was added in https://chromiumcodereview.appspot.com/10913066 / 
https://chromiumcodereview.appspot.com/16632009 . Did you check the TEST= lines
in those two CLs are still working with this gone?

[erikchen, 2013/12/30 19:20:34]

I've manually tested the repro conditions with both magic mouse and track pad,
and the bugs do not reproduce. Unsurprisingly, the unit tests fail.

-
 - (void)loadView {
   const gfx::Image& image =
       ui::ResourceBundle::GetSharedInstance().GetNativeImageNamed(
@@ -166,6 +159,9 @@ const CGFloat kShieldHeightCompletionAdjust = 10;
 }
 
 - (void)animationDidStop:(CAAnimation*)theAnimation finished:(BOOL)finished {
+  [[BrowserWindowController
+      browserWindowControllerForView:[self view]] onOverlappedViewHidden];
+  [self.view removeFromSuperview];
   // Destroy the CAAnimation and its strong reference to its delegate (this
   // class).
   [self.view setAnimations:nil];