mac: Fix a history swiper bug where the shield wouldn't disappear.

chrome/browser/ui/cocoa/history_overlay_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/history_overlay_controller.h"
 
 #include "base/logging.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #include "grit/theme_resources.h"
 #include "ui/base/resource/resource_bundle.h"
@@ skipping 71 matching lines @@
 
 - (id)initForMode:(HistoryOverlayMode)mode {
   if ((self = [super init])) {
     mode_ = mode;
     DCHECK(mode == kHistoryOverlayModeBack ||
            mode == kHistoryOverlayModeForward);
   }
   return self;
 }
 
-- (void)dealloc {
-  [[BrowserWindowController
-      browserWindowControllerForView:[self view]] onOverlappedViewHidden];
-  [self.view removeFromSuperview];
-  [super dealloc];
-}

[Nico, 2013/12/27 23:56:13]

This was added in https://chromiumcodereview.appspot.com/10913066 / 
https://chromiumcodereview.appspot.com/16632009 . Did you check the TEST= lines
in those two CLs are still working with this gone?

[erikchen, 2013/12/30 19:20:34]

I've manually tested the repro conditions with both magic mouse and track pad,
and the bugs do not reproduce. Unsurprisingly, the unit tests fail.

-
 - (void)loadView {
   const gfx::Image& image =
       ui::ResourceBundle::GetSharedInstance().GetNativeImageNamed(
           mode_ == kHistoryOverlayModeBack ? IDR_SWIPE_BACK
                                            : IDR_SWIPE_FORWARD);
   contentView_.reset(
       [[HistoryOverlayView alloc] initWithMode:mode_
                                          image:image.ToNSImage()]);
   self.view = contentView_;
 }
@@ skipping 50 matching lines @@
   [animation setDelegate:self];
   [animation setDuration:kFadeOutDurationSeconds];
   NSMutableDictionary* dictionary =
       [NSMutableDictionary dictionaryWithCapacity:1];
   [dictionary setObject:animation forKey:@"alphaValue"];
   [overlay setAnimations:dictionary];
   [[overlay animator] setAlphaValue:0.0];
 }
 
 - (void)animationDidStop:(CAAnimation*)theAnimation finished:(BOOL)finished {
+  [[BrowserWindowController
+      browserWindowControllerForView:[self view]] onOverlappedViewHidden];
+  [self.view removeFromSuperview];
   // Destroy the CAAnimation and its strong reference to its delegate (this
   // class).
   [self.view setAnimations:nil];
 }
 
 @end