Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1073153002: Code Cleanup for extension_prefs, as AddDisableReasons() is not required same behavior can be achie… (Closed)

Created:
5 years, 8 months ago by Deepak
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Code Cleanup for extension_prefs, as AddDisableReasons() is not required same behavior can be achieved by AddDisableReason(). BUG=475911 Committed: https://crrev.com/f5c302712f48ae014617ea242ef49f3e3f757be3 Cr-Commit-Position: refs/heads/master@{#325387}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M chrome/browser/extensions/extension_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/extension_prefs.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/extension_prefs.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Deepak
PTAL for this small clean up. Thanks
5 years, 8 months ago (2015-04-10 13:19:17 UTC) #2
Deepak
PTAL for this small clean up. Thanks
5 years, 8 months ago (2015-04-13 15:16:24 UTC) #3
Deepak
@rockot PTAL at this small change.
5 years, 8 months ago (2015-04-15 07:19:34 UTC) #5
Ken Rockot(use gerrit already)
lgtm
5 years, 8 months ago (2015-04-15 17:09:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073153002/1
5 years, 8 months ago (2015-04-16 02:38:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 03:30:53 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 03:31:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5c302712f48ae014617ea242ef49f3e3f757be3
Cr-Commit-Position: refs/heads/master@{#325387}

Powered by Google App Engine
This is Rietveld 408576698