Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: extensions/browser/extension_prefs.h

Issue 1073153002: Code Cleanup for extension_prefs, as AddDisableReasons() is not required same behavior can be achie… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | extensions/browser/extension_prefs.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_EXTENSION_PREFS_H_ 5 #ifndef EXTENSIONS_BROWSER_EXTENSION_PREFS_H_
6 #define EXTENSIONS_BROWSER_EXTENSION_PREFS_H_ 6 #define EXTENSIONS_BROWSER_EXTENSION_PREFS_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 244 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 void SetDidExtensionEscalatePermissions( 255 void SetDidExtensionEscalatePermissions(
256 const Extension* extension, 256 const Extension* extension,
257 bool did_escalate); 257 bool did_escalate);
258 258
259 // Getters and setters for disabled reason. 259 // Getters and setters for disabled reason.
260 int GetDisableReasons(const std::string& extension_id) const; 260 int GetDisableReasons(const std::string& extension_id) const;
261 bool HasDisableReason(const std::string& extension_id, 261 bool HasDisableReason(const std::string& extension_id,
262 Extension::DisableReason disable_reason) const; 262 Extension::DisableReason disable_reason) const;
263 void AddDisableReason(const std::string& extension_id, 263 void AddDisableReason(const std::string& extension_id,
264 Extension::DisableReason disable_reason); 264 Extension::DisableReason disable_reason);
265 void AddDisableReasons(const std::string& extension_id, int disable_reasons);
266 void RemoveDisableReason(const std::string& extension_id, 265 void RemoveDisableReason(const std::string& extension_id,
267 Extension::DisableReason disable_reason); 266 Extension::DisableReason disable_reason);
268 void ClearDisableReasons(const std::string& extension_id); 267 void ClearDisableReasons(const std::string& extension_id);
269 268
270 // Gets the set of extensions that have been blacklisted in prefs. This will 269 // Gets the set of extensions that have been blacklisted in prefs. This will
271 // return only the blocked extensions, not the "greylist" extensions. 270 // return only the blocked extensions, not the "greylist" extensions.
272 // TODO(oleg): Make method names consistent here, in extension service and in 271 // TODO(oleg): Make method names consistent here, in extension service and in
273 // blacklist. 272 // blacklist.
274 std::set<std::string> GetBlacklistedExtensions(); 273 std::set<std::string> GetBlacklistedExtensions();
275 274
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
686 bool extensions_disabled_; 685 bool extensions_disabled_;
687 686
688 ObserverList<ExtensionPrefsObserver> observer_list_; 687 ObserverList<ExtensionPrefsObserver> observer_list_;
689 688
690 DISALLOW_COPY_AND_ASSIGN(ExtensionPrefs); 689 DISALLOW_COPY_AND_ASSIGN(ExtensionPrefs);
691 }; 690 };
692 691
693 } // namespace extensions 692 } // namespace extensions
694 693
695 #endif // EXTENSIONS_BROWSER_EXTENSION_PREFS_H_ 694 #endif // EXTENSIONS_BROWSER_EXTENSION_PREFS_H_
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | extensions/browser/extension_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698