content/browser/service_worker/service_worker_dispatcher_host.cc - Issue 1072933006: Support whitelisting to handle insecure origins as trustworthy origins (chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.cc

Issue 1072933006: Support whitelisting to handle insecure origins as trustworthy origins (chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added test, added IsOriginSecure plumbing etc Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/chrome_content_renderer_client.cc ('K') | « chrome/renderer/chrome_content_renderer_client.cc ('k') | content/content_common.gypi » ('j') | content/public/common/content_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_dispatcher_host.cc

diff --git a/content/browser/service_worker/service_worker_dispatcher_host.cc b/content/browser/service_worker/service_worker_dispatcher_host.cc

index 3340f871853af14d17d1567f3b6680e016326c36..8c95a82efac06e3be0c57b84945e2566679e5f53 100644

--- a/content/browser/service_worker/service_worker_dispatcher_host.cc

+++ b/content/browser/service_worker/service_worker_dispatcher_host.cc

@@ -50,12 +50,8 @@ bool AllOriginsMatch(const GURL& url_a, const GURL& url_b, const GURL& url_c) {

url_a.GetOrigin() == url_c.GetOrigin();

}

-// TODO(dominicc): When crbug.com/362214 is fixed use that to be

-// consistent with Blink's

-// SecurityOrigin::canAccessFeatureRequiringSecureOrigin.

bool OriginCanAccessServiceWorkers(const GURL& url) {

- return url.SchemeIsHTTPOrHTTPS() &&

- (url.SchemeIsSecure() || net::IsLocalhost(url.host()));

+ return GetContentClient()->IsOriginTrustWorthy(url);

}

bool CanRegisterServiceWorker(const GURL& document_url,