chrome/renderer/chrome_content_renderer_client.cc - Issue 1072933006: Support whitelisting to handle insecure origins as trustworthy origins (chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 1072933006: Support whitelisting to handle insecure origins as trustworthy origins (chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added test, added IsOriginSecure plumbing etc Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/origin_util.cc ('K') | « chrome/common/origin_util_unittest.cc ('k') | content/browser/service_worker/service_worker_dispatcher_host.cc » ('j') | content/public/common/content_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/chrome_content_renderer_client.cc

diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc

index 0c254e7f57e32c5dc5d1c050cd71bba748d47754..511f06153c7a2931961960b04817a82af55577e7 100644

--- a/chrome/renderer/chrome_content_renderer_client.cc

+++ b/chrome/renderer/chrome_content_renderer_client.cc

@@ -20,6 +20,7 @@

#include "chrome/common/crash_keys.h"

#include "chrome/common/extensions/extension_metrics.h"

#include "chrome/common/localized_error.h"

+#include "chrome/common/origin_util.h"

#include "chrome/common/pepper_permission_util.h"

#include "chrome/common/render_messages.h"

#include "chrome/common/url_constants.h"

@@ -509,6 +510,10 @@ void ChromeContentRendererClient::RenderThreadStarted() {

pdf_print_client_.reset(new ChromePDFPrintClient());

pdf::PPB_PDF_Impl::SetPrintClient(pdf_print_client_.get());

#endif

+ const std::set<GURL>& origins = GetWhiteListedSecureOrigins();

+ for (const GURL& origin : origins)

palmer 2015/04/20 22:16:18 Nit: auto here too?

+ WebSecurityPolicy::addOriginTrustworthyWhiteList(origin);

}

void ChromeContentRendererClient::RenderFrameCreated(