Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2059)

Unified Diff: Source/modules/notifications/Notification.h

Issue 1072873002: Clean up Blink left-overs of textual persistent notification ids. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/notifications/Notification.h
diff --git a/Source/modules/notifications/Notification.h b/Source/modules/notifications/Notification.h
index 77a79313558bed5c1b68261eac10dfc7c3b5a79a..3d214d5aff23e4fcfbd0d8d818526e33e25afeb3 100644
--- a/Source/modules/notifications/Notification.h
+++ b/Source/modules/notifications/Notification.h
@@ -65,8 +65,6 @@ public:
// Used for embedder-created Notification objects. Will initialize the Notification's state as showing.
static Notification* create(ExecutionContext*, int64_t persistentId, const WebNotificationData&);
- // TODO(peter): Remove this method when the embedder only passes us int64_t persistent notification ids.
- static Notification* create(ExecutionContext*, const String& persistentId, const WebNotificationData&);
virtual ~Notification();
@@ -133,7 +131,6 @@ private:
void setSerializedData(PassRefPtr<SerializedScriptValue> data) { m_serializedData = data; }
void setPersistentId(int64_t persistentId) { m_persistentId = persistentId; }
- void setPersistentIdString(const String& persistentId) { m_persistentIdString = persistentId; }
private:
String m_title;
@@ -150,7 +147,6 @@ private:
// their delegate, or persistent, which means they're identified by a persistent Id
// given to us by the embedder. This influences how we close the notification.
int64_t m_persistentId;
- String m_persistentIdString;
enum NotificationState {
NotificationStateIdle,

Powered by Google App Engine
This is Rietveld 408576698