Avoid considering readonly password elements in password form

components/autofill/content/renderer/password_form_conversion_utils.cc

Index: components/autofill/content/renderer/password_form_conversion_utils.cc
diff --git a/components/autofill/content/renderer/password_form_conversion_utils.cc b/components/autofill/content/renderer/password_form_conversion_utils.cc
index 7ad5814273126fa24f9014b298a63b3ed370cebd..0c85b9a73e4ef3e42bf5bd81f0f1448103a00d34 100644
--- a/components/autofill/content/renderer/password_form_conversion_utils.cc
+++ b/components/autofill/content/renderer/password_form_conversion_utils.cc
@@ -254,7 +254,12 @@ void GetPasswordForm(
         layout_sequence.push_back('N');
     }
 
-    if (input_element->isPasswordField()) {
+    // If the password field is readonly, the page is likely using a virtual
+    // keyboard and bypassing the password field value (see http://crbug.com/475488)

[vabr (Chromium), 2015/04/10 10:45:38]

nit: Also, a full-stop (".") is missing after the closing parenthesis.

[vabr (Chromium), 2015/04/10 10:45:38]

nit: Here the comment ran over the 80 characters per line limit. If you use
clang-format (you should), then the easiest way to sort this out is to keep all
comments one one line, and use "git cl format" before uploading. This way
clang-format wraps the comments fro you correctly. Please note that clang-format
does not join multiple comment lines before wrapping, so it is important to keep
the whole comment on one (long) line before doing the automatic formatting.

[ramya.v, 2015/04/13 03:01:44]

Done.

[ramya.v, 2015/04/13 03:01:44]

Done.

+    // There is nothing Chrome can do to fill passwords for now.
+    if (input_element->isPasswordField() && (!input_element->isReadOnly() ||
+      HasAutocompleteAttributeValue(*input_element, "current_password") ||
+      HasAutocompleteAttributeValue(*input_element, "new-password"))) {
       passwords.push_back(*input_element);
       // If we have not yet considered any element to be the username so far,
       // provisionally select the input element just before the first password