Avoid considering readonly password elements in password form

components/autofill/content/renderer/password_form_conversion_utils.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/password_form_conversion_utils.h"
 
 #include <vector>
 
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 236 matching lines @@
     if (!input_element || !input_element->isEnabled())
       continue;
 
     if (input_element->isTextField()) {
       if (input_element->isPasswordField())
         layout_sequence.push_back('P');
       else
         layout_sequence.push_back('N');
     }
 
-    if (input_element->isPasswordField()) {
+    // If the password field is readonly, the page is likely using a virtual
+    // keyboard and bypassing the password field value (see http://crbug.com/475488)

[vabr (Chromium), 2015/04/10 10:45:38]

nit: Also, a full-stop (".") is missing after the closing parenthesis.

[vabr (Chromium), 2015/04/10 10:45:38]

nit: Here the comment ran over the 80 characters per line limit. If you use
clang-format (you should), then the easiest way to sort this out is to keep all
comments one one line, and use "git cl format" before uploading. This way
clang-format wraps the comments fro you correctly. Please note that clang-format
does not join multiple comment lines before wrapping, so it is important to keep
the whole comment on one (long) line before doing the automatic formatting.

[ramya.v, 2015/04/13 03:01:44]

Done.

[ramya.v, 2015/04/13 03:01:44]

Done.

+    // There is nothing Chrome can do to fill passwords for now.
+    if (input_element->isPasswordField() && (!input_element->isReadOnly() ||
+      HasAutocompleteAttributeValue(*input_element, "current_password") ||
+      HasAutocompleteAttributeValue(*input_element, "new-password"))) {
       passwords.push_back(*input_element);
       // If we have not yet considered any element to be the username so far,
       // provisionally select the input element just before the first password
       // element to be the username. This choice will be overruled if we later
       // find an element with autocomplete='username'.
       if (username_element.isNull() && !latest_input_element.isNull()) {
         username_element = latest_input_element;
         // Remove the selected username from other_possible_usernames.
         if (!latest_input_element.value().isEmpty()) {
           DCHECK(!other_possible_usernames.empty());
@@ skipping 175 matching lines @@
                            blink::WebFormControlElement(),
                            REQUIRE_NONE,
                            EXTRACT_NONE,
                            &password_form->form_data,
                            NULL /* FormFieldData */);
 
   return password_form.Pass();
 }
 
 }  // namespace autofill