Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1072743002: [turbofan] Materialize JSFunction from frame if possible. (Closed)

Created:
5 years, 8 months ago by Benedikt Meurer
Modified:
5 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Materialize JSFunction from frame if possible. This reduces the overhead of recursive calls when context specialization is enabled. Based on this it might be possible to further reduce the overhead by also specializing the call itself. As a drive-by-fix, port the fast context materialization optimization to arm and arm64, that was previously only supported on x64 and ia32. R=svenpanne@chromium.org Committed: https://crrev.com/725cdc533cb4e31c042d32ce1979012b5bd99ced Cr-Commit-Position: refs/heads/master@{#27686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -3 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +17 lines, -2 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +15 lines, -1 line 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 8 months ago (2015-04-09 06:54:20 UTC) #1
Benedikt Meurer
Hey Sven, This is a trivial optimization, that avoids having to materialize the JSFunction as ...
5 years, 8 months ago (2015-04-09 06:57:29 UTC) #2
Sven Panne
lgtm
5 years, 8 months ago (2015-04-09 07:06:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072743002/1
5 years, 8 months ago (2015-04-09 07:06:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 07:41:15 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 07:41:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/725cdc533cb4e31c042d32ce1979012b5bd99ced
Cr-Commit-Position: refs/heads/master@{#27686}

Powered by Google App Engine
This is Rietveld 408576698