Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: src/compiler/arm64/code-generator-arm64.cc

Issue 1072743002: [turbofan] Materialize JSFunction from frame if possible. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/arm/code-generator-arm.cc ('k') | src/compiler/ia32/code-generator-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/arm64/code-generator-arm64.cc
diff --git a/src/compiler/arm64/code-generator-arm64.cc b/src/compiler/arm64/code-generator-arm64.cc
index 762b57a6bc2a8778bdd4f0a3b368e155e1a92953..c0f22b70636ba0c54b8dff29de08af5394040485 100644
--- a/src/compiler/arm64/code-generator-arm64.cc
+++ b/src/compiler/arm64/code-generator-arm64.cc
@@ -1126,7 +1126,21 @@ void CodeGenerator::AssembleMove(InstructionOperand* source,
Register dst = destination->IsRegister() ? g.ToRegister(destination)
: scope.AcquireX();
if (src.type() == Constant::kHeapObject) {
- __ LoadObject(dst, src.ToHeapObject());
+ Handle<HeapObject> src_object = src.ToHeapObject();
+ if (info()->IsOptimizing() &&
+ src_object.is_identical_to(info()->context())) {
+ // Loading the context from the frame is way cheaper than
+ // materializing the actual context heap object address.
+ __ Ldr(dst, MemOperand(fp, StandardFrameConstants::kContextOffset));
+ } else if (info()->IsOptimizing() &&
+ src_object.is_identical_to(info()->closure())) {
+ // Loading the JSFunction from the frame is way cheaper than
+ // materializing the actual JSFunction heap object address.
+ __ Ldr(dst,
+ MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
+ } else {
+ __ LoadObject(dst, src_object);
+ }
} else {
__ Mov(dst, g.ToImmediate(source));
}
« no previous file with comments | « src/compiler/arm/code-generator-arm.cc ('k') | src/compiler/ia32/code-generator-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698