Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1072483002: Pass --undefok to DM and nanobench for more graceful branch failure. (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
Reviewers:
borenet
CC:
Stephen White, msarett, chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Pass --undefok to DM and nanobench for more graceful branch failure. Is there a way to do this only if not running against master? BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294718

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -2 lines) Patch
M scripts/slave/recipe_modules/skia/api.py View 2 chunks +7 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Perf-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Perf-Win7-MSVC-ShuttleA-GPU-HD2000-x86-Release-Trybot.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-GalaxyS4-GPU-SGX544-Arm7-Debug.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-Nexus10-GPU-MaliT604-Arm7-Release.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-Nexus5-GPU-Adreno330-Arm7-Debug.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-NexusPlayer-GPU-PowerVR-x86-Debug.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-Xoom-GPU-Tegra2-Arm7-Debug.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-ChromeOS-GCC-Daisy-CPU-NEON-Arm7-Release.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-ChromeOS-GCC-Link-CPU-AVX-x86_64-Debug.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Mac10.8-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Debug-ZeroGPUCache.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 5 chunks +5 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Win7-MSVC-ShuttleA-GPU-HD2000-x86-Release.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Win7-MSVC-ShuttleA-GPU-HD2000-x86-Release-ANGLE.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Win8-MSVC-ShuttleA-CPU-AVX-x86_64-Debug.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/failed_dm.json View 2 chunks +2 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/failed_get_hashes.json View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein_C
5 years, 8 months ago (2015-04-08 14:46:58 UTC) #2
borenet
LGTM. I guess we could use "git merge-base" to determine whether self.got_revision is an ancestor ...
5 years, 8 months ago (2015-04-08 14:52:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072483002/1
5 years, 8 months ago (2015-04-08 15:07:17 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 15:09:59 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294718

Powered by Google App Engine
This is Rietveld 408576698