scripts/slave/recipe_modules/skia/api.py - Issue 1072483002: Pass --undefok to DM and nanobench for more graceful branch failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/skia/api.py

Issue 1072483002: Pass --undefok to DM and nanobench for more graceful branch failure. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/skia/api.py

diff --git a/scripts/slave/recipe_modules/skia/api.py b/scripts/slave/recipe_modules/skia/api.py

index 3f6e178a3a15e543f5ac9d69d332c859593728d5..17774b9736c7bb5a511da08c54d1a34f7bc9f679 100644

--- a/scripts/slave/recipe_modules/skia/api.py

+++ b/scripts/slave/recipe_modules/skia/api.py

@@ -316,6 +316,7 @@ class SkiaApi(recipe_api.RecipeApi):

# Run DM.

args = [

'dm',

+ '--undefok', # This helps branches that may not know new flags.

'--verbose',

'--resourcePath', self.device_dirs.resource_dir,

'--skps', self.device_dirs.skp_dir,

@@ -394,8 +395,12 @@ class SkiaApi(recipe_api.RecipeApi):

self.flavor.create_clean_device_dir(self.device_dirs.perf_data_dir)

# Run nanobench.

- args = ['nanobench', '-i', self.device_dirs.resource_dir,

- '--skps', self.device_dirs.skp_dir]

+ args = [

+ 'nanobench',

+ '--undefok', # This helps branches that may not know new flags.

+ '-i', self.device_dirs.resource_dir,

+ '--skps', self.device_dirs.skp_dir

+ ]

skip_flag = None

if self.c.builder_cfg.get('cpu_or_gpu') == 'CPU':

« no previous file with comments | « no previous file | scripts/slave/recipes/skia/skia.expected/Perf-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release.json » ('j') | no next file with comments »