Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1072273007: Improve the curve tessellation subdivision of the path renderers. (Closed)

Created:
5 years, 8 months ago by Stephen White
Modified:
5 years, 8 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Improve the curve tessellation subdivision of the path renderers. The stencil-and-cover and tessellating path renderers currently tessellate curves to linear segments to within one screen space pixel. This is fairly poor accuracy, as can be seen from the strokecircle GM: there are noticeable rotating bumps on the circles. Improving the tolerance to 0.25 pixel eliminates the bumps, and approximates the 16x supersampling of the raster path. This does have a performance hit: 3-6% on desktop on the IE chalkboard demo, ~1% on Nexus 7 2013. Note: this will require rebaselining a number of GPU and MSAA images in Skia, but nothing in Chrome (yet). BUG=skia:3731 Committed: https://skia.googlesource.com/skia/+/2b4bb07492790d7d18dc046f05999915d4384c5d

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M src/gpu/GrDefaultPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPathUtils.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Stephen White
Brian: PTAL. Thanks!
5 years, 8 months ago (2015-04-22 20:23:49 UTC) #2
bsalomon
lgtm
5 years, 8 months ago (2015-04-22 20:25:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072273007/20001
5 years, 8 months ago (2015-04-22 20:30:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/2b4bb07492790d7d18dc046f05999915d4384c5d
5 years, 8 months ago (2015-04-22 20:45:22 UTC) #6
tomhudson
I think we're seeing 50-100% regression on Android for the tiger & map SVG test ...
5 years, 8 months ago (2015-04-23 17:16:23 UTC) #7
Stephen White
5 years, 8 months ago (2015-04-23 17:30:45 UTC) #8
Message was sent while issue was closed.
On 2015/04/23 17:16:23, tomhudson wrote:
> I think we're seeing 50-100% regression on Android for the tiger & map SVG
test
> cases. Is this really warranted?
> 
> https://perf.skia.org/#3251

Sadly, yes. The quality is simply not acceptable with out (see the SVG tiger's
eye, for example). 

OTOH, there's a flaw in the way that the skia perf tests measure timings on the
GPU which overweights the cost of CPU work, and underweights the cost of GPU
work (I've been meaning to file a bug about this once I have the data.) So this
regression is not as bad as it looks, in terms of whole-system performance.

Powered by Google App Engine
This is Rietveld 408576698