Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1899)

Unified Diff: Source/modules/accessibility/AXScrollbar.h

Issue 1072273006: Oilpan: Prepare moving AXObject to heap (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXScrollView.cpp ('k') | Source/modules/accessibility/AXScrollbar.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXScrollbar.h
diff --git a/Source/modules/accessibility/AXScrollbar.h b/Source/modules/accessibility/AXScrollbar.h
index 847b872dcaf135c6a73ee0aabf4bc6b508095352..c0e683d7f98509f61ed2a0242f21968a856a3893 100644
--- a/Source/modules/accessibility/AXScrollbar.h
+++ b/Source/modules/accessibility/AXScrollbar.h
@@ -38,7 +38,9 @@ class Scrollbar;
class AXScrollbar final : public AXMockObject {
public:
- static PassRefPtr<AXScrollbar> create(Scrollbar*, AXObjectCacheImpl&);
+ static PassRefPtrWillBeRawPtr<AXScrollbar> create(Scrollbar*, AXObjectCacheImpl&);
+ virtual ~AXScrollbar();
+ DECLARE_VIRTUAL_TRACE();
Scrollbar* scrollbar() const { return m_scrollbar.get(); }
@@ -62,9 +64,7 @@ private:
virtual void setValue(float) override;
virtual float valueForRange() const override;
- // FIXME: Oilpan: turn this into a Member once the AXObject
- // hierarchy is on the heap.
- RefPtrWillBePersistent<Scrollbar> m_scrollbar;
+ RefPtrWillBeMember<Scrollbar> m_scrollbar;
};
DEFINE_AX_OBJECT_TYPE_CASTS(AXScrollbar, isAXScrollbar());
« no previous file with comments | « Source/modules/accessibility/AXScrollView.cpp ('k') | Source/modules/accessibility/AXScrollbar.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698