Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1646)

Unified Diff: Source/modules/accessibility/AXScrollbar.cpp

Issue 1072273006: Oilpan: Prepare moving AXObject to heap (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXScrollbar.h ('k') | Source/modules/accessibility/AXSlider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXScrollbar.cpp
diff --git a/Source/modules/accessibility/AXScrollbar.cpp b/Source/modules/accessibility/AXScrollbar.cpp
index 54d441b04924514d9f0c227025738fa578d92f9c..eae8a5cd26a0580301cc2986095622b97318940f 100644
--- a/Source/modules/accessibility/AXScrollbar.cpp
+++ b/Source/modules/accessibility/AXScrollbar.cpp
@@ -42,15 +42,20 @@ AXScrollbar::AXScrollbar(Scrollbar* scrollbar, AXObjectCacheImpl& axObjectCache)
ASSERT(scrollbar);
}
+AXScrollbar::~AXScrollbar()
+{
+ ASSERT(!m_scrollbar);
+}
+
void AXScrollbar::detachFromParent()
{
m_scrollbar = nullptr;
AXMockObject::detachFromParent();
}
-PassRefPtr<AXScrollbar> AXScrollbar::create(Scrollbar* scrollbar, AXObjectCacheImpl& axObjectCache)
+PassRefPtrWillBeRawPtr<AXScrollbar> AXScrollbar::create(Scrollbar* scrollbar, AXObjectCacheImpl& axObjectCache)
{
- return adoptRef(new AXScrollbar(scrollbar, axObjectCache));
+ return adoptRefWillBeNoop(new AXScrollbar(scrollbar, axObjectCache));
}
LayoutRect AXScrollbar::elementRect() const
@@ -111,4 +116,10 @@ void AXScrollbar::setValue(float value)
m_scrollbar->scrollableArea()->setScrollPositionSingleAxis(m_scrollbar->orientation(), newValue, ProgrammaticScroll);
}
+DEFINE_TRACE(AXScrollbar)
+{
+ visitor->trace(m_scrollbar);
+ AXMockObject::trace(visitor);
+}
+
} // namespace blink
« no previous file with comments | « Source/modules/accessibility/AXScrollbar.h ('k') | Source/modules/accessibility/AXSlider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698