Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2090)

Unified Diff: Source/modules/accessibility/AXNodeObject.h

Issue 1072273006: Oilpan: Prepare moving AXObject to heap (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/accessibility/AXNodeObject.h
diff --git a/Source/modules/accessibility/AXNodeObject.h b/Source/modules/accessibility/AXNodeObject.h
index 037659b82681e94fcf0761d4b2468a85b8ba7b11..7b228952e39fa69e83a8668ad8fed00382a9b3f4 100644
--- a/Source/modules/accessibility/AXNodeObject.h
+++ b/Source/modules/accessibility/AXNodeObject.h
@@ -46,8 +46,9 @@ protected:
AXNodeObject(Node*, AXObjectCacheImpl*);
public:
- static PassRefPtr<AXNodeObject> create(Node*, AXObjectCacheImpl*);
+ static PassRefPtrWillBeRawPtr<AXNodeObject> create(Node*, AXObjectCacheImpl*);
virtual ~AXNodeObject();
+ DECLARE_VIRTUAL_TRACE();
protected:
// Protected data.
@@ -167,7 +168,7 @@ protected:
virtual String computedName() const override;
// New AX name calculation.
- virtual String textAlternative(bool recursive, bool inAriaLabelledByTraversal, HashSet<AXObject*>& visited, AXNameFrom*, Vector<AXObject*>* nameObjects) override;
+ virtual String textAlternative(bool recursive, bool inAriaLabelledByTraversal, WillBeHeapHashSet<RawPtrWillBeMember<AXObject>>& visited, AXNameFrom*, WillBeHeapVector<RawPtrWillBeMember<AXObject>>* nameObjects) override;
// Location and click point in frame-relative coordinates.
virtual LayoutRect elementRect() const override;
@@ -206,11 +207,11 @@ protected:
virtual int setSize() const override;
private:
- Node* m_node;
+ RawPtrWillBeWeakMember<Node> m_node;
haraken 2015/05/28 10:48:40 Why does this need to be weak? What confuses me i
String alternativeTextForWebArea() const;
- void alternativeText(Vector<AccessibilityText>&) const;
- void ariaLabeledByText(Vector<AccessibilityText>&) const;
+ void alternativeText(WillBeHeapVector<OwnPtrWillBeMember<AccessibilityText>>&) const;
+ void ariaLabeledByText(WillBeHeapVector<OwnPtrWillBeMember<AccessibilityText>>&) const;
float stepValueForRange() const;
AXObject* findChildWithTagName(const HTMLQualifiedName&) const;
bool isDescendantOfElementType(const HTMLQualifiedName& tagName) const;

Powered by Google App Engine
This is Rietveld 408576698