Oilpan: Prepare moving AXObject to heap

Source/modules/accessibility/AXNodeObject.h

 /*
  * Copyright (C) 2012, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 28 matching lines @@
 class Element;
 class HTMLLabelElement;
 class LayoutRect;
 class Node;
 
 class MODULES_EXPORT AXNodeObject : public AXObject {
 protected:
     AXNodeObject(Node*, AXObjectCacheImpl*);
 
 public:
-    static PassRefPtr<AXNodeObject> create(Node*, AXObjectCacheImpl*);
+    static PassRefPtrWillBeRawPtr<AXNodeObject> create(Node*, AXObjectCacheImpl*);
     virtual ~AXNodeObject();
+    DECLARE_VIRTUAL_TRACE();
 
 protected:
     // Protected data.
     AccessibilityRole m_ariaRole;
     bool m_childrenDirty;
 #if ENABLE(ASSERT)
     bool m_initialized;
 #endif
 
     virtual bool computeAccessibilityIsIgnored(IgnoredReasons* = nullptr) const override;
@@ skipping 99 matching lines @@
     virtual AccessibilityOptionalBool isAriaGrabbed() const override final;
 
     // Accessibility Text.
     virtual String deprecatedTextUnderElement(TextUnderElementMode) const override;
     virtual String deprecatedAccessibilityDescription() const override;
     virtual String deprecatedTitle(TextUnderElementMode) const override;
     virtual String deprecatedHelpText() const override;
     virtual String computedName() const override;
 
     // New AX name calculation.
-    virtual String textAlternative(bool recursive, bool inAriaLabelledByTraversal, HashSet<AXObject*>& visited, AXNameFrom*, Vector<AXObject*>* nameObjects) override;
+    virtual String textAlternative(bool recursive, bool inAriaLabelledByTraversal, WillBeHeapHashSet<RawPtrWillBeMember<AXObject>>& visited, AXNameFrom*, WillBeHeapVector<RawPtrWillBeMember<AXObject>>* nameObjects) override;
 
     // Location and click point in frame-relative coordinates.
     virtual LayoutRect elementRect() const override;
 
     // High-level accessibility tree access.
     virtual AXObject* computeParent() const override;
     virtual AXObject* computeParentIfExists() const override;
 
     // Low-level accessibility tree exploration.
     virtual AXObject* firstChild() const override;
@@ skipping 18 matching lines @@
     virtual void childrenChanged() override;
     virtual void selectionChanged() override final;
     virtual void textChanged() override;
     virtual void updateAccessibilityRole() override final;
 
     // Position in set and Size of set
     virtual int posInSet() const override;
     virtual int setSize() const override;
 
 private:
-    Node* m_node;
+    RawPtrWillBeWeakMember<Node> m_node;

[haraken, 2015/05/28 10:48:40]

Why does this need to be weak?

What confuses me is that you sometimes use WeakMembers in AXObjects and
sometimes Members. What's the difference? I think all AXObjects should hold a
Member to the object they are observing, because the AXObject and the
corresponding element should live and die together.

 
     String alternativeTextForWebArea() const;
-    void alternativeText(Vector<AccessibilityText>&) const;
-    void ariaLabeledByText(Vector<AccessibilityText>&) const;
+    void alternativeText(WillBeHeapVector<OwnPtrWillBeMember<AccessibilityText>>&) const;
+    void ariaLabeledByText(WillBeHeapVector<OwnPtrWillBeMember<AccessibilityText>>&) const;
     float stepValueForRange() const;
     AXObject* findChildWithTagName(const HTMLQualifiedName&) const;
     bool isDescendantOfElementType(const HTMLQualifiedName& tagName) const;
 };
 
 DEFINE_AX_OBJECT_TYPE_CASTS(AXNodeObject, isAXNodeObject());
 
 } // namespace blink
 
 #endif // AXNodeObject_h