Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1071963002: Replace Handle<> with Local<> in bindings/core/v8 (Closed)

Created:
5 years, 8 months ago by deepak.s
Modified:
5 years, 8 months ago
Reviewers:
haraken, vivekg
CC:
vivekg, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replace Handle<> with Local<> in bindings/core/v8 v8::Handle<T> is just an alias of v8::Local<T>. BUG=424445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193531

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -97 lines) Patch
M Source/bindings/core/v8/DOMDataStore.h View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/core/v8/Dictionary.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/Dictionary.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptFunction.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptFunction.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/ScriptString.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ScriptString.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/V8DOMActivityLogger.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8DOMWrapper.h View 8 chunks +13 lines, -13 lines 0 comments Download
M Source/bindings/core/v8/V8DOMWrapper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8EventListenerList.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/core/v8/V8GCController.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/core/v8/V8HiddenValue.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/V8HiddenValue.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/V8IteratorResultValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8IteratorResultValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8NPObject.cpp View 11 chunks +11 lines, -11 lines 0 comments Download
M Source/bindings/core/v8/V8NPUtils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8NPUtils.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/V8ValueCache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8ValueCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/WindowProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/WindowProxy.cpp View 11 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
deepak.s
PTAL?
5 years, 8 months ago (2015-04-09 10:07:46 UTC) #2
vivekg
l-g-t-m. Lets wait for bots to turn green and haraken's words.
5 years, 8 months ago (2015-04-09 10:29:10 UTC) #4
haraken
LGTM
5 years, 8 months ago (2015-04-09 10:38:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071963002/1
5 years, 8 months ago (2015-04-10 07:17:52 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 10:24:47 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193531

Powered by Google App Engine
This is Rietveld 408576698