Source/bindings/core/v8/V8ValueCache.cpp - Issue 1071963002: Replace Handle<> with Local<> in bindings/core/v8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8ValueCache.cpp

Issue 1071963002: Replace Handle<> with Local<> in bindings/core/v8 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/V8ValueCache.cpp

diff --git a/Source/bindings/core/v8/V8ValueCache.cpp b/Source/bindings/core/v8/V8ValueCache.cpp

index 8d81aa749591e5bde8bc476dfb7131612fc714b8..53be40eb5b389017e14452f1648e34214733bf39 100644

--- a/Source/bindings/core/v8/V8ValueCache.cpp

+++ b/Source/bindings/core/v8/V8ValueCache.cpp

@@ -75,7 +75,7 @@ static v8::Local<v8::String> makeExternalString(const String& string, v8::Isolat

return newString;

}

-v8::Handle<v8::String> StringCache::v8ExternalStringSlow(v8::Isolate* isolate, StringImpl* stringImpl)

+v8::Local<v8::String> StringCache::v8ExternalStringSlow(v8::Isolate* isolate, StringImpl* stringImpl)

{

if (!stringImpl->length())

return v8::String::Empty(isolate);

« no previous file with comments | « Source/bindings/core/v8/V8ValueCache.h ('k') | Source/bindings/core/v8/WindowProxy.h » ('j') | no next file with comments »