Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 107183004: Only 'form associated' elements have a potential form owner. (Closed)

Created:
7 years ago by sof
Modified:
7 years ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Only 'form associated' elements have a potential form owner. The spec tells us that only certain elements have the notion of a form owner, http://www.whatwg.org/specs/web-apps/current-work//#form-owner http://www.whatwg.org/specs/web-apps/current-work//#form-associated-element Implement that selective notion of 'form owner' over elements. This aligns with Gecko and Trident (IE11.) For the associated bug, use such form ownership to provide the expected chain of lexical environments when compiling event handlers. Or, more to the point, not provide an enclosing form's scope if the elemen isn't a form-associated element. While making the required changes here, a slight bug in the handling of an <option>'s ".form" property was spotted & is addressed here also. i.e., a "free-floating" <option> (no <select> parent) within a form should have a ".form" property mapped to null, http://www.whatwg.org/specs/web-apps/current-work//#dom-option-form All other implementations follow the spec in this regard. R= BUG=324828 TEST=fast/forms/form-associated-element TEST=fast/forms/form-attribute

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -35 lines) Patch
A LayoutTests/fast/forms/form-associated-element.html View 1 chunk +68 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/form-associated-element-expected.txt View 1 chunk +53 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/form-attribute.html View 1 chunk +13 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/form-attribute-expected.txt View 1 chunk +5 lines, -1 line 0 comments Download
M Source/bindings/v8/V8LazyEventListener.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 2 chunks +10 lines, -4 lines 0 comments Download
M Source/core/html/HTMLButtonElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLElement.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/html/HTMLFieldSetElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLImageElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLInputElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLKeygenElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLabelElement.h View 3 chunks +3 lines, -1 line 0 comments Download
M Source/core/html/HTMLLabelElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLabelElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLegendElement.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLLegendElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLObjectElement.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/html/HTMLObjectElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptionElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/html/HTMLOutputElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/RadioNodeList.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sof
Please take a look when you have a chance. [To make the spec correspondence clear, ...
7 years ago (2013-12-09 17:41:09 UTC) #1
tkent
On 2013/12/09 17:41:09, sof wrote: > Please take a look when you have a chance. ...
7 years ago (2013-12-10 02:01:36 UTC) #2
sof
On 2013/12/10 02:01:36, tkent wrote: > On 2013/12/09 17:41:09, sof wrote: > > Please take ...
7 years ago (2013-12-10 06:17:39 UTC) #3
sof
7 years ago (2013-12-10 14:51:11 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698