Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1325)

Unified Diff: chrome/browser/ui/pdf/pdf_unsupported_feature.cc

Issue 107183002: Move more of the plugin code in the renderer to use RenderFrame instead of RenderView. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/pdf/pdf_unsupported_feature.cc
===================================================================
--- chrome/browser/ui/pdf/pdf_unsupported_feature.cc (revision 238847)
+++ chrome/browser/ui/pdf/pdf_unsupported_feature.cc (working copy)
@@ -27,6 +27,7 @@
#include "content/public/browser/navigation_details.h"
#include "content/public/browser/navigation_entry.h"
#include "content/public/browser/plugin_service.h"
+#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/user_metrics.h"
@@ -141,9 +142,9 @@
void OpenUsingReader(WebContents* web_contents,
const WebPluginInfo& reader_plugin,
OpenPDFInReaderPromptDelegate* delegate) {
- ChromePluginServiceFilter::GetInstance()->OverridePluginForTab(
+ ChromePluginServiceFilter::GetInstance()->OverridePluginForFrame(
web_contents->GetRenderProcessHost()->GetID(),
- web_contents->GetRenderViewHost()->GetRoutingID(),
+ web_contents->GetMainFrame()->GetRoutingID(),
nasko 2013/12/05 22:43:45 Wouldn't this cause overrides to only be stored fo
jam 2013/12/05 23:14:07 we only show the page action for top-level pdfs, s
web_contents->GetURL(),
reader_plugin);
web_contents->GetRenderViewHost()->ReloadFrame();

Powered by Google App Engine
This is Rietveld 408576698