chrome/browser/printing/print_preview_dialog_controller.cc - Issue 107183002: Move more of the plugin code in the renderer to use RenderFrame instead of RenderView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_dialog_controller.cc

Issue 107183002: Move more of the plugin code in the renderer to use RenderFrame instead of RenderView. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/plugins/plugin_info_message_filter.cc ('k') | chrome/browser/ui/pdf/pdf_unsupported_feature.cc » ('j') | chrome/browser/ui/pdf/pdf_unsupported_feature.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_preview_dialog_controller.cc

===================================================================

--- chrome/browser/printing/print_preview_dialog_controller.cc (revision 238847)

+++ chrome/browser/printing/print_preview_dialog_controller.cc (working copy)

@@ -34,6 +34,7 @@

#include "content/public/browser/notification_details.h"

#include "content/public/browser/notification_source.h"

#include "content/public/browser/plugin_service.h"

+#include "content/public/browser/render_frame_host.h"

#include "content/public/browser/render_process_host.h"

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/web_contents.h"

@@ -63,9 +64,9 @@

pdf_plugin_path, &pdf_plugin))

return;

- ChromePluginServiceFilter::GetInstance()->OverridePluginForTab(

+ ChromePluginServiceFilter::GetInstance()->OverridePluginForFrame(

preview_dialog->GetRenderProcessHost()->GetID(),

- preview_dialog->GetRenderViewHost()->GetRoutingID(),

+ preview_dialog->GetMainFrame()->GetRoutingID(),

nasko 2013/12/05 22:43:45 Similar to the other case, this will act on the ma

jam 2013/12/05 23:14:07 same as other comment, this is only done for top l

GURL(), pdf_plugin);

}