Move more of the plugin code in the renderer to use RenderFrame instead of RenderView.

Move more of the plugin code in the renderer to use RenderFrame instead of RenderView.

This is part of the work of making ContentRendererClient's OverrideCreatePlugin and CreatePluginReplacement take only a RenderFrame. I'm still not there yet, which is why their signatures haven't been trimmed.

BUG=304341
R=fsamuel@chromium.org, nasko@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239075

[jam, 2013-12-05 21:25:38]

fsamuel: chrome/browser/extensions/* per our chat
jschuh: IPCs were moved from one file to another as before
nasko: the rest

[Fady Samuel, 2013-12-05 21:30:17]

lgtm chrome/browser/extensions/*

[nasko, 2013-12-05 22:43:44]

Some questions and nits.

https://codereview.chromium.org/107183002/diff/40001/chrome/browser/printing/...
File chrome/browser/printing/print_preview_dialog_controller.cc (right):

https://codereview.chromium.org/107183002/diff/40001/chrome/browser/printing/...
chrome/browser/printing/print_preview_dialog_controller.cc:69:
preview_dialog->GetMainFrame()->GetRoutingID(),
Similar to the other case, this will act on the main frame and if subframe asks
for the plugin, it will get different answer.

https://codereview.chromium.org/107183002/diff/40001/chrome/browser/ui/pdf/pd...
File chrome/browser/ui/pdf/pdf_unsupported_feature.cc (right):

https://codereview.chromium.org/107183002/diff/40001/chrome/browser/ui/pdf/pd...
chrome/browser/ui/pdf/pdf_unsupported_feature.cc:147:
web_contents->GetMainFrame()->GetRoutingID(),
Wouldn't this cause overrides to only be stored for the main frame and if a
subframe tries to use unsupported feature, it won't be allowed?
Is this a supported case?

https://codereview.chromium.org/107183002/diff/40001/content/browser/renderer...
File content/browser/renderer_host/render_message_filter.cc (right):

https://codereview.chromium.org/107183002/diff/40001/content/browser/renderer...
content/browser/renderer_host/render_message_filter.cc:404:
IPC_MESSAGE_HANDLER(FrameHostMsg_GetPluginInfo, OnGetPluginInfo)
nit: I wonder if it will be helpful to group all FrameHostMsg together and
ViewHostMsg together. It will make it easier to see what parts live where.

https://codereview.chromium.org/107183002/diff/40001/content/child/resource_d...
File content/child/resource_dispatcher_unittest.cc (right):

https://codereview.chromium.org/107183002/diff/40001/content/child/resource_d...
content/child/resource_dispatcher_unittest.cc:178: false, 0, true, 0, GURL(),
nit: MSG_ROUTING_NONE?

https://codereview.chromium.org/107183002/diff/40001/content/public/browser/r...
File content/public/browser/resource_request_info.h (right):

https://codereview.chromium.org/107183002/diff/40001/content/public/browser/r...
content/public/browser/resource_request_info.h:68: // GetRouteID above.
Do we need to get rid of all RenderView or do we just need the point where all
navigations and resource requests route to RenderFrame?

https://codereview.chromium.org/107183002/diff/40001/content/renderer/render_...
File content/renderer/render_frame_impl.h (right):

https://codereview.chromium.org/107183002/diff/40001/content/renderer/render_...
content/renderer/render_frame_impl.h:163: virtual int GetRoutingID() OVERRIDE;
Does it make sense to have both routing_id() and GetRoutingID()? They both do
the same.

[jam, 2013-12-05 23:14:07]

https://codereview.chromium.org/107183002/diff/40001/chrome/browser/printing/...
File chrome/browser/printing/print_preview_dialog_controller.cc (right):

https://codereview.chromium.org/107183002/diff/40001/chrome/browser/printing/...
chrome/browser/printing/print_preview_dialog_controller.cc:69:
preview_dialog->GetMainFrame()->GetRoutingID(),
On 2013/12/05 22:43:45, nasko wrote:
> Similar to the other case, this will act on the main frame and if subframe
asks
> for the plugin, it will get different answer.

same as other comment, this is only done for top level frame (btw I verified
both cases)

https://codereview.chromium.org/107183002/diff/40001/chrome/browser/ui/pdf/pd...
File chrome/browser/ui/pdf/pdf_unsupported_feature.cc (right):

https://codereview.chromium.org/107183002/diff/40001/chrome/browser/ui/pdf/pd...
chrome/browser/ui/pdf/pdf_unsupported_feature.cc:147:
web_contents->GetMainFrame()->GetRoutingID(),
On 2013/12/05 22:43:45, nasko wrote:
> Wouldn't this cause overrides to only be stored for the main frame and if a
> subframe tries to use unsupported feature, it won't be allowed?
> Is this a supported case?

we only show the page action for top-level pdfs, so it's not an issue

https://codereview.chromium.org/107183002/diff/40001/content/browser/renderer...
File content/browser/renderer_host/render_message_filter.cc (right):

https://codereview.chromium.org/107183002/diff/40001/content/browser/renderer...
content/browser/renderer_host/render_message_filter.cc:404:
IPC_MESSAGE_HANDLER(FrameHostMsg_GetPluginInfo, OnGetPluginInfo)
On 2013/12/05 22:43:45, nasko wrote:
> nit: I wonder if it will be helpful to group all FrameHostMsg together and
> ViewHostMsg together. It will make it easier to see what parts live where.

Eventually they'll all be FrameHostMsg, so I'm wary of doing a bunch of code
churn for this.

https://codereview.chromium.org/107183002/diff/40001/content/child/resource_d...
File content/child/resource_dispatcher_unittest.cc (right):

https://codereview.chromium.org/107183002/diff/40001/content/child/resource_d...
content/child/resource_dispatcher_unittest.cc:178: false, 0, true, 0, GURL(),
On 2013/12/05 22:43:45, nasko wrote:
> nit: MSG_ROUTING_NONE?

Done.

https://codereview.chromium.org/107183002/diff/40001/content/public/browser/r...
File content/public/browser/resource_request_info.h (right):

https://codereview.chromium.org/107183002/diff/40001/content/public/browser/r...
content/public/browser/resource_request_info.h:68: // GetRouteID above.
On 2013/12/05 22:43:45, nasko wrote:
> Do we need to get rid of all RenderView or do we just need the point where all
> navigations and resource requests route to RenderFrame?

you're right, that's more specific and sooner. I've updated comment

https://codereview.chromium.org/107183002/diff/40001/content/renderer/render_...
File content/renderer/render_frame_impl.h (right):

https://codereview.chromium.org/107183002/diff/40001/content/renderer/render_...
content/renderer/render_frame_impl.h:163: virtual int GetRoutingID() OVERRIDE;
On 2013/12/05 22:43:45, nasko wrote:
> Does it make sense to have both routing_id() and GetRoutingID()? They both do
> the same.

yep only one needed, removed routing_id()

[nasko, 2013-12-05 23:46:15]

LGTM

[nasko, 2013-12-05 23:47:59]

Adding the review list.