chrome/browser/ui/pdf/pdf_unsupported_feature.cc - Issue 107183002: Move more of the plugin code in the renderer to use RenderFrame instead of RenderView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/pdf/pdf_unsupported_feature.cc

Issue 107183002: Move more of the plugin code in the renderer to use RenderFrame instead of RenderView. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: review comments Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/pdf/pdf_unsupported_feature.cc

===================================================================

--- chrome/browser/ui/pdf/pdf_unsupported_feature.cc (revision 238847)

+++ chrome/browser/ui/pdf/pdf_unsupported_feature.cc (working copy)

@@ -27,6 +27,7 @@

#include "content/public/browser/navigation_details.h"

#include "content/public/browser/navigation_entry.h"

#include "content/public/browser/plugin_service.h"

+#include "content/public/browser/render_frame_host.h"

#include "content/public/browser/render_process_host.h"

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/user_metrics.h"

@@ -141,9 +142,9 @@

void OpenUsingReader(WebContents* web_contents,

const WebPluginInfo& reader_plugin,

OpenPDFInReaderPromptDelegate* delegate) {

- ChromePluginServiceFilter::GetInstance()->OverridePluginForTab(

+ ChromePluginServiceFilter::GetInstance()->OverridePluginForFrame(

web_contents->GetRenderProcessHost()->GetID(),

- web_contents->GetRenderViewHost()->GetRoutingID(),

+ web_contents->GetMainFrame()->GetRoutingID(),

web_contents->GetURL(),

reader_plugin);

web_contents->GetRenderViewHost()->ReloadFrame();

« no previous file with comments | « chrome/browser/printing/print_preview_dialog_controller.cc ('k') | chrome/common/render_messages.h » ('j') | no next file with comments »