Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1823)

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.h

Issue 1071773003: Remove persistent notifications from the database when they close. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-db-Integrate
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/platform_notification_service_impl.h
diff --git a/chrome/browser/notifications/platform_notification_service_impl.h b/chrome/browser/notifications/platform_notification_service_impl.h
index ce32031dc0fe318e741cf7c71f66fde9ac9a3644..759e6a1221c795c9c479a903fffcd90e4c38b19f 100644
--- a/chrome/browser/notifications/platform_notification_service_impl.h
+++ b/chrome/browser/notifications/platform_notification_service_impl.h
@@ -42,6 +42,14 @@ class PlatformNotificationServiceImpl
const base::Callback<void(content::PersistentNotificationStatus)>&
callback) const;
+ // To be called when a persistent notification has been closed. The data
+ // associated with the notification has to be pruned from the database in this
+ // case, to make sure that it continues to be in sync.
johnme 2015/04/10 11:54:39 Nit: Must be called on the UI thread.
Peter Beverloo 2015/04/20 16:47:20 Done.
+ void OnPersistentNotificationClose(
+ content::BrowserContext* browser_context,
johnme 2015/04/10 11:54:39 Why not just take a Profile* since this is the chr
Peter Beverloo 2015/04/20 16:47:20 It only needs to know about the BrowserContext*, s
+ int64_t persistent_notification_id,
+ const GURL& origin) const;
+
// Returns the Notification UI Manager through which notifications can be
// displayed to the user. Can be overridden for testing.
NotificationUIManager* GetNotificationUIManager() const;

Powered by Google App Engine
This is Rietveld 408576698