chrome/browser/notifications/persistent_notification_delegate.cc - Issue 1071773003: Remove persistent notifications from the database when they close.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/persistent_notification_delegate.cc

Issue 1071773003: Remove persistent notifications from the database when they close. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-db-Integrate

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/notification_ui_manager_android.cc ('K') | « chrome/browser/notifications/notification_ui_manager_android.cc ('k') | chrome/browser/notifications/platform_notification_service_impl.h » ('j') | chrome/browser/notifications/platform_notification_service_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/persistent_notification_delegate.cc

diff --git a/chrome/browser/notifications/persistent_notification_delegate.cc b/chrome/browser/notifications/persistent_notification_delegate.cc

index 84a2576605af4cebfafc8a8f483ffa4f8338a9a6..55d571408102f370995e2e21eac7b36513d19944 100644

--- a/chrome/browser/notifications/persistent_notification_delegate.cc

+++ b/chrome/browser/notifications/persistent_notification_delegate.cc

@@ -30,7 +30,12 @@ PersistentNotificationDelegate::~PersistentNotificationDelegate() {}

void PersistentNotificationDelegate::Display() {}

-void PersistentNotificationDelegate::Close(bool by_user) {}

+void PersistentNotificationDelegate::Close(bool by_user) {

+ PlatformNotificationServiceImpl::GetInstance()->OnPersistentNotificationClose(

+ browser_context_,

+ persistent_notification_id_,

+ origin_);

void PersistentNotificationDelegate::Click() {

PlatformNotificationServiceImpl::GetInstance()->OnPersistentNotificationClick(