Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1071733003: Revert of Make allow_subannotations more robust. (Closed)

Created:
5 years, 8 months ago by luqui
Modified:
5 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, cmp-cc_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Revert of Make allow_subannotations more robust. (patchset #7 id:120001 of https://codereview.chromium.org/1001183002/) Reason for revert: Maybe it broke extract_build Original issue's description: > Make allow_subannotations more robust. > > This patch makes the recipe engine parse and re-emit subannotations when allow_subannotations is True. This means that any of the subannotator's steps which are duplicates of other steps executed will be disambiguated. When an allow_subannotations step is actually emits annotations, an (end) step is emitted after it is done to have something to hang metadata on (it also conveniently communicates when we re-enter recipes). > > BUG=466409 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294727 TBR=iannucci@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466409 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294729

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -291 lines) Patch
M scripts/common/annotator.py View 6 chunks +17 lines, -23 lines 0 comments Download
M scripts/slave/annotated_run.py View 10 chunks +62 lines, -152 lines 0 comments Download
M scripts/slave/recipe_modules/step/api.py View 2 chunks +9 lines, -0 lines 0 comments Download
D scripts/slave/recipes/example/subannotations.py View 1 chunk +0 lines, -48 lines 0 comments Download
D scripts/slave/recipes/example/subannotations.expected/basic.json View 1 chunk +0 lines, -67 lines 0 comments Download
M scripts/slave/unittests/recipe_simulation_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
luqui
Created Revert of Make allow_subannotations more robust.
5 years, 8 months ago (2015-04-08 20:57:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071733003/1
5 years, 8 months ago (2015-04-08 20:57:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=294729
5 years, 8 months ago (2015-04-08 20:57:52 UTC) #3
luqui
5 years, 8 months ago (2015-04-08 22:25:10 UTC) #4
Message was sent while issue was closed.
Reland here https://codereview.chromium.org/1076643002/

Powered by Google App Engine
This is Rietveld 408576698