Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1450)

Unified Diff: scripts/slave/recipe_modules/step/api.py

Issue 1071733003: Revert of Make allow_subannotations more robust. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/annotated_run.py ('k') | scripts/slave/recipes/example/subannotations.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/step/api.py
diff --git a/scripts/slave/recipe_modules/step/api.py b/scripts/slave/recipe_modules/step/api.py
index 4864e827538e65b7e72e48c88400eea221574bc1..b3c44557b553c4b8369eae50de41a7b747ab91d6 100644
--- a/scripts/slave/recipe_modules/step/api.py
+++ b/scripts/slave/recipe_modules/step/api.py
@@ -8,6 +8,10 @@
# Inherit from RecipeApiPlain because the only thing which is a step is
# run_from_dict()
class StepApi(recipe_api.RecipeApiPlain):
+ def __init__(self, **kwargs):
+ super(StepApi, self).__init__(**kwargs)
+ self._step_names = {}
+
EXCEPTION = 'EXCEPTION'
FAILURE = 'FAILURE'
SUCCESS = 'SUCCESS'
@@ -91,6 +95,11 @@
command = list(wrapper)
command += cmd
+ step_count = self._step_names.setdefault(name, 0) + 1
+ self._step_names[name] = step_count
+ if step_count > 1:
+ name = "%s (%d)" % (name, step_count)
+
kwargs.update({'name': name, 'cmd': command})
kwargs['ok_ret'] = ok_ret
kwargs['infra_step'] = bool(infra_step)
« no previous file with comments | « scripts/slave/annotated_run.py ('k') | scripts/slave/recipes/example/subannotations.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698