Issue 1071703002: Remove some duplication in code that extracts the source for a function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1071703002: Remove some duplication in code that extracts the source for a function. (Closed)

Created:
5 years, 8 months ago by rmacnak

Modified:
5 years, 8 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

More Reviews

Description

Remove some duplication in code that extracts the source for a function. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=45145

Patch Set 1 #

Total comments: 1

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -57 lines)			Patch
M	runtime/lib/mirrors.cc	View	1 chunk	+1 line, -39 lines	0 comments	Download
M	runtime/vm/compiler_test.cc	View	2 chunks	+2 lines, -2 lines	1 comment	Download
M	runtime/vm/object.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+39 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

siva

lgtm https://codereview.chromium.org/1071703002/diff/1/runtime/vm/compiler_test.cc File runtime/vm/compiler_test.cc (right): https://codereview.chromium.org/1071703002/diff/1/runtime/vm/compiler_test.cc#newcode70 runtime/vm/compiler_test.cc:70: function_source.ToCString()); maybe better to retain the new line ...

5 years, 8 months ago (2015-04-14 18:00:45 UTC) #3

rmacnak

5 years, 8 months ago (2015-04-14 19:41:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 45145 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages