Remove some duplication in code that extracts the source for a function.

runtime/vm/compiler_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/class_finalizer.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
 #include "vm/dart_api_impl.h"
 #include "vm/object.h"
@@ skipping 36 matching lines @@
   EXPECT(CompilerTest::TestCompileScript(lib, script));
   EXPECT(ClassFinalizer::ProcessPendingClasses());
   Class& cls = Class::Handle(
       lib.LookupClass(String::Handle(Symbols::New("A"))));
   EXPECT(!cls.IsNull());
   String& function_foo_name = String::Handle(String::New("foo"));
   Function& function_foo =
       Function::Handle(cls.LookupStaticFunction(function_foo_name));
   EXPECT(!function_foo.IsNull());
   String& function_source = String::Handle(function_foo.GetSource());
-  EXPECT_STREQ("static foo() { return 42; }\n  ", function_source.ToCString());
+  EXPECT_STREQ("static foo() { return 42; }", function_source.ToCString());
   EXPECT(CompilerTest::TestCompileFunction(function_foo));
   EXPECT(function_foo.HasCode());
 
   String& function_moo_name = String::Handle(String::New("moo"));
   Function& function_moo =
       Function::Handle(cls.LookupStaticFunction(function_moo_name));
   EXPECT(!function_moo.IsNull());
 
   EXPECT(CompilerTest::TestCompileFunction(function_moo));
   EXPECT(function_moo.HasCode());
   function_source = function_moo.GetSource();
-  EXPECT_STREQ("static moo() {\n    // A.foo();\n  }\n",
+  EXPECT_STREQ("static moo() {\n    // A.foo();\n  }",
                function_source.ToCString());

[siva, 2015/04/14 18:00:45]

maybe better to retain the new line as it would look cleaner when an error
happens.

 }
 
 
 TEST_CASE(RegenerateAllocStubs) {
   const char* kScriptChars =
             "class A {\n"
             "}\n"
             "unOpt() => new A(); \n"
             "optIt() => new A(); \n"
             "A main() {\n"
@@ skipping 92 matching lines @@
     val = lib.Evaluate(expression, Array::empty_array(), Array::empty_array());
   }
 
   EXPECT(!val.IsNull());
   EXPECT(!val.IsError());
   EXPECT(val.IsInteger());
   EXPECT_EQ(7, Integer::Cast(val).AsInt64Value());
 }
 
 }  // namespace dart