Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1071683002: IndexedDB: Use C++11 in-class member initializers (Closed)

Created:
5 years, 8 months ago by jsbell
Modified:
5 years, 8 months ago
Reviewers:
cmumford
CC:
cmumford, chromium-reviews, darin-cc_chromium.org, dgrogan, jam, jsbell+idb_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Use C++11 in-class member initializers Remove some redundant number_(0) initializers. Also, for IndexedDBKey, use number_ for both number and date type to save memory. R=cmumford@chromium.org Committed: https://crrev.com/4e4c7e9880e46a427f6030cc6b4fa83e73a79e7e Cr-Commit-Position: refs/heads/master@{#324347}

Patch Set 1 #

Patch Set 2 : Actually try building it... #

Patch Set 3 : Fix copy/pasta #

Total comments: 6

Patch Set 4 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -25 lines) Patch
M content/common/indexed_db/indexed_db_key.h View 1 2 3 3 chunks +22 lines, -7 lines 0 comments Download
M content/common/indexed_db/indexed_db_key.cc View 1 4 chunks +1 line, -8 lines 0 comments Download
M content/common/indexed_db/indexed_db_key_range.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/indexed_db/indexed_db_key_range.cc View 1 2 3 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
jsbell
cmumford@ - please take a look?
5 years, 8 months ago (2015-04-08 21:38:10 UTC) #1
cmumford
https://codereview.chromium.org/1071683002/diff/40001/content/common/indexed_db/indexed_db_key.h File content/common/indexed_db/indexed_db_key.h (right): https://codereview.chromium.org/1071683002/diff/40001/content/common/indexed_db/indexed_db_key.h#newcode46 content/common/indexed_db/indexed_db_key.h:46: DCHECK(type_ == blink::WebIDBKeyTypeArray); DCHECK_EQ - also for the others ...
5 years, 8 months ago (2015-04-08 22:16:32 UTC) #2
jsbell
https://codereview.chromium.org/1071683002/diff/40001/content/common/indexed_db/indexed_db_key.h File content/common/indexed_db/indexed_db_key.h (right): https://codereview.chromium.org/1071683002/diff/40001/content/common/indexed_db/indexed_db_key.h#newcode46 content/common/indexed_db/indexed_db_key.h:46: DCHECK(type_ == blink::WebIDBKeyTypeArray); On 2015/04/08 22:16:32, cmumford wrote: > ...
5 years, 8 months ago (2015-04-08 23:09:52 UTC) #3
cmumford
lgtm
5 years, 8 months ago (2015-04-08 23:12:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071683002/60001
5 years, 8 months ago (2015-04-08 23:15:53 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-09 02:54:38 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 02:55:23 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/4e4c7e9880e46a427f6030cc6b4fa83e73a79e7e
Cr-Commit-Position: refs/heads/master@{#324347}

Powered by Google App Engine
This is Rietveld 408576698