IndexedDB: Use C++11 in-class member initializers

content/common/indexed_db/indexed_db_key_range.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/indexed_db/indexed_db_key_range.h"
 
 #include "base/logging.h"
 #include "third_party/WebKit/public/platform/WebIDBTypes.h"
 
 namespace content {
 
-IndexedDBKeyRange::IndexedDBKeyRange()
-    : lower_(blink::WebIDBKeyTypeNull),
-      upper_(blink::WebIDBKeyTypeNull),
-      lower_open_(false),
-      upper_open_(false) {}
+IndexedDBKeyRange::IndexedDBKeyRange() {

[cmumford, 2015/04/08 22:16:32]

IndexedDBKeyRange::IndexedDBKeyRange() = default;

[jsbell, 2015/04/08 23:09:52]

Done.

+}
 
 IndexedDBKeyRange::IndexedDBKeyRange(const IndexedDBKey& lower,
                                      const IndexedDBKey& upper,
                                      bool lower_open,
                                      bool upper_open)
     : lower_(lower),
       upper_(upper),
       lower_open_(lower_open),
       upper_open_(upper_open) {}
 
 IndexedDBKeyRange::IndexedDBKeyRange(const IndexedDBKey& key)
-    : lower_(key), upper_(key), lower_open_(false), upper_open_(false) {}
+    : lower_(key), upper_(key) {

[cmumford, 2015/04/08 22:16:32]

I'm assuming compilers are smart enough to not initialize lower_/upper_ twice?

[jsbell, 2015/04/08 23:09:52]

Correct. At least according to:

http://www.stroustrup.com/C++11FAQ.html#member-init

+}
 
 IndexedDBKeyRange::IndexedDBKeyRange(const IndexedDBKeyRange& other) = default;
 IndexedDBKeyRange::~IndexedDBKeyRange() = default;
 IndexedDBKeyRange& IndexedDBKeyRange::operator=(
     const IndexedDBKeyRange& other) = default;
 
 bool IndexedDBKeyRange::IsOnlyKey() const {
   if (lower_open_ || upper_open_)
     return false;
 
   return lower_.Equals(upper_);
 }
 
 }  // namespace content