Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issue 1071603006: Fix the browser crash in reattaching ServiceWorker to existing DevTools window. (Closed)

Created:
5 years, 8 months ago by horo
Modified:
5 years, 8 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, kinuko+watch, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the browser crash in reattaching ServiceWorker to existing DevTools window. BUG=475328 Committed: https://crrev.com/9833ab4d43289646ccec09a134a7a1d0f1c444c8 Cr-Commit-Position: refs/heads/master@{#324396}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/devtools/service_worker_devtools_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
horo
pfeldman@ Could you please review this?
5 years, 8 months ago (2015-04-09 01:54:44 UTC) #2
dgozman
lgtm
5 years, 8 months ago (2015-04-09 05:20:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071603006/1
5 years, 8 months ago (2015-04-09 06:53:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 08:23:58 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 08:24:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9833ab4d43289646ccec09a134a7a1d0f1c444c8
Cr-Commit-Position: refs/heads/master@{#324396}

Powered by Google App Engine
This is Rietveld 408576698