content/browser/devtools/service_worker_devtools_manager.cc - Issue 1071603006: Fix the browser crash in reattaching ServiceWorker to existing DevTools window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/service_worker_devtools_manager.cc

Issue 1071603006: Fix the browser crash in reattaching ServiceWorker to existing DevTools window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/devtools/service_worker_devtools_manager.cc

diff --git a/content/browser/devtools/service_worker_devtools_manager.cc b/content/browser/devtools/service_worker_devtools_manager.cc

index 9b639c6fe6d85db117860f796d5e026bc4e6ce40..a423066d12e2c5339fefba62e7683b918aa5cb21 100644

--- a/content/browser/devtools/service_worker_devtools_manager.cc

+++ b/content/browser/devtools/service_worker_devtools_manager.cc

@@ -91,7 +91,7 @@ bool ServiceWorkerDevToolsManager::WorkerCreated(

workers_[id] = agent_host;

DevToolsManager::GetInstance()->AgentHostChanged(agent_host);

- return it->second->IsAttached();

+ return agent_host->IsAttached();

}

void ServiceWorkerDevToolsManager::WorkerReadyForInspection(

« no previous file with comments | « no previous file | no next file » | no next file with comments »