Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: content/browser/indexed_db/indexed_db_factory_impl.cc

Issue 1071553002: Optimizes the operation of DeleteDatabase when no backing store exists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Optimizes the operation of DeleteDatabase when no backing store exists. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/indexed_db/indexed_db_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/indexed_db/indexed_db_factory_impl.cc
diff --git a/content/browser/indexed_db/indexed_db_factory_impl.cc b/content/browser/indexed_db/indexed_db_factory_impl.cc
index f818f3f6181f7adff689abe7ec8308c47d497cfd..a0cbcaa72d392ad9e451e5389311a80fed1b3cf2 100644
--- a/content/browser/indexed_db/indexed_db_factory_impl.cc
+++ b/content/browser/indexed_db/indexed_db_factory_impl.cc
@@ -257,6 +257,27 @@ void IndexedDBFactoryImpl::DeleteDatabase(
return;
}
+ std::vector<base::string16> names = backing_store->GetDatabaseNames(&s);
+ if (!s.ok()) {
+ DLOG(ERROR) << "Internal error getting database names";
+ IndexedDBDatabaseError error(blink::WebIDBDatabaseExceptionUnknownError,
+ "Internal error opening backing store for "
+ "indexedDB.webkitGetDatabaseNames.");
jsbell 2015/04/13 16:32:39 This should be "indexedDB.deleteDatabase"
+ callbacks->OnError(error);
+ backing_store = NULL;
+ if (s.IsCorruption())
+ HandleBackingStoreCorruption(origin_url, error);
+ return;
+ }
+ if(std::find(names.begin(), names.end(), name) == names.end())
jsbell 2015/04/13 16:32:39 #include "base/stl_util.h" and use: base::Contain
jsbell 2015/04/13 16:32:40 Space between if and ( please use `git cl format`
+ {
jsbell 2015/04/13 16:32:40 { should be on same line as if please use `git cl
+ int64 version = 0;
jsbell 2015/04/13 16:32:40 Make this const
+ callbacks->OnSuccess(version);
+ backing_store = NULL;
+ ReleaseBackingStore(origin_url, false );
jsbell 2015/04/13 16:32:39 Please document the use of false here (e.g. /* imm
jsbell 2015/04/13 16:32:39 No space before ) please use `git cl format` befo
+ return;
+ }
+
scoped_refptr<IndexedDBDatabase> database = IndexedDBDatabase::Create(
name, backing_store.get(), this, unique_identifier, &s);
if (!database.get()) {
« no previous file with comments | « content/browser/indexed_db/indexed_db_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698