Optimizes the operation of DeleteDatabase when no backing store exists.

content/browser/indexed_db/indexed_db_factory_impl.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/indexed_db_factory_impl.h"
 
 #include <utility>
 #include <vector>
 
 #include "base/logging.h"
@@ skipping 239 matching lines @@
                                  ASCIIToUTF16(
                                      "Internal error opening backing store "
                                      "for indexedDB.deleteDatabase."));
     callbacks->OnError(error);
     if (s.IsCorruption()) {
       HandleBackingStoreCorruption(origin_url, error);
     }
     return;
   }
 
+  std::vector<base::string16> names = backing_store->GetDatabaseNames(&s);
+  if (!s.ok()) {
+    DLOG(ERROR) << "Internal error getting database names";
+    IndexedDBDatabaseError error(blink::WebIDBDatabaseExceptionUnknownError,
+                                 "Internal error opening backing store for "
+                                 "indexedDB.webkitGetDatabaseNames.");

[jsbell, 2015/04/13 16:32:39]

This should be "indexedDB.deleteDatabase"

+    callbacks->OnError(error);
+    backing_store = NULL;
+    if (s.IsCorruption())
+      HandleBackingStoreCorruption(origin_url, error);
+    return;
+  }
+  if(std::find(names.begin(), names.end(), name) == names.end())

[jsbell, 2015/04/13 16:32:39]

#include "base/stl_util.h" and use:

base::ContainsKey(names, name)

[jsbell, 2015/04/13 16:32:40]

Space between if and (

please use `git cl format` before uploading

+  {

[jsbell, 2015/04/13 16:32:40]

{ should be on same line as if

please use `git cl format` before uploading

+    int64 version = 0;

[jsbell, 2015/04/13 16:32:40]

Make this const

+    callbacks->OnSuccess(version);
+    backing_store = NULL;
+    ReleaseBackingStore(origin_url, false );

[jsbell, 2015/04/13 16:32:39]

Please document the use of false here (e.g. /* immediate */ false)

[jsbell, 2015/04/13 16:32:39]

No space before )

please use `git cl format` before uploading.

+    return;
+  }
+
   scoped_refptr<IndexedDBDatabase> database = IndexedDBDatabase::Create(
       name, backing_store.get(), this, unique_identifier, &s);
   if (!database.get()) {
     IndexedDBDatabaseError error(
         blink::WebIDBDatabaseExceptionUnknownError,
         ASCIIToUTF16(
             "Internal error creating database backend for "
             "indexedDB.deleteDatabase."));
     callbacks->OnError(error);
     if (s.IsCorruption()) {
@@ skipping 224 matching lines @@
   size_t count(0);
 
   OriginDBs range = GetOpenDatabasesForOrigin(origin_url);
   for (OriginDBMapIterator it = range.first; it != range.second; ++it)
     count += it->second->ConnectionCount();
 
   return count;
 }
 
 }  // namespace content