Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1915)

Unified Diff: Source/modules/accessibility/AXObject.cpp

Issue 1071483002: Implement aria properties setsize and posinset. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressing Comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/accessibility/AXObject.cpp
diff --git a/Source/modules/accessibility/AXObject.cpp b/Source/modules/accessibility/AXObject.cpp
index 55c4a517c4e225c8aea22265ddab2e4bd875aa22..884745d3dbcec62653cad311c1923365f686e462 100644
--- a/Source/modules/accessibility/AXObject.cpp
+++ b/Source/modules/accessibility/AXObject.cpp
@@ -719,6 +719,17 @@ bool AXObject::supportsRangeValue() const
|| isSpinButton();
}
+bool AXObject::supportssetSizePosInSet() const
+{
+ if (parentObject() && ((roleValue() == ListBoxOptionRole && parentObject()->roleValue() == ListBoxRole)
shreeramk 2015/04/09 13:50:15 I'd like your feedback on this check condition.
dmazzoni 2015/04/09 15:19:20 This looks right, but it should also apply to List
+ || (roleValue() == ListItemRole && parentObject()->roleValue() == ListRole)
+ || (roleValue() == RadioButtonRole && parentObject()->roleValue() == RadioGroupRole)
+ || (roleValue() == TabRole && parentObject()->roleValue() == TabListRole)))
+ return true;
+
+ return false;
+}
+
void AXObject::ariaTreeRows(AccessibilityChildrenVector& result)
{
for (const auto& child : children()) {

Powered by Google App Engine
This is Rietveld 408576698