Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: Source/modules/accessibility/AXObject.cpp

Issue 1071483002: Implement aria properties setsize and posinset. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressing Comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 701 matching lines...) Expand 10 before | Expand all | Expand 10 after
712 712
713 bool AXObject::supportsRangeValue() const 713 bool AXObject::supportsRangeValue() const
714 { 714 {
715 return isProgressIndicator() 715 return isProgressIndicator()
716 || isMeter() 716 || isMeter()
717 || isSlider() 717 || isSlider()
718 || isScrollbar() 718 || isScrollbar()
719 || isSpinButton(); 719 || isSpinButton();
720 } 720 }
721 721
722 bool AXObject::supportssetSizePosInSet() const
723 {
724 if (parentObject() && ((roleValue() == ListBoxOptionRole && parentObject()-> roleValue() == ListBoxRole)
shreeramk 2015/04/09 13:50:15 I'd like your feedback on this check condition.
dmazzoni 2015/04/09 15:19:20 This looks right, but it should also apply to List
725 || (roleValue() == ListItemRole && parentObject()->roleValue() == ListRo le)
726 || (roleValue() == RadioButtonRole && parentObject()->roleValue() == Rad ioGroupRole)
727 || (roleValue() == TabRole && parentObject()->roleValue() == TabListRole )))
728 return true;
729
730 return false;
731 }
732
722 void AXObject::ariaTreeRows(AccessibilityChildrenVector& result) 733 void AXObject::ariaTreeRows(AccessibilityChildrenVector& result)
723 { 734 {
724 for (const auto& child : children()) { 735 for (const auto& child : children()) {
725 // Add tree items as the rows. 736 // Add tree items as the rows.
726 if (child->roleValue() == TreeItemRole) 737 if (child->roleValue() == TreeItemRole)
727 result.append(child); 738 result.append(child);
728 739
729 // Now see if this item also has rows hiding inside of it. 740 // Now see if this item also has rows hiding inside of it.
730 child->ariaTreeRows(result); 741 child->ariaTreeRows(result);
731 } 742 }
(...skipping 568 matching lines...) Expand 10 before | Expand all | Expand 10 after
1300 } 1311 }
1301 1312
1302 const AtomicString& AXObject::internalRoleName(AccessibilityRole role) 1313 const AtomicString& AXObject::internalRoleName(AccessibilityRole role)
1303 { 1314 {
1304 static const Vector<AtomicString>* internalRoleNameVector = createInternalRo leNameVector(); 1315 static const Vector<AtomicString>* internalRoleNameVector = createInternalRo leNameVector();
1305 1316
1306 return internalRoleNameVector->at(role); 1317 return internalRoleNameVector->at(role);
1307 } 1318 }
1308 1319
1309 } // namespace blink 1320 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698