Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1071423003: Revert "Fix locking for printing error messages." (Closed)

Created:
5 years, 8 months ago by Karl
Modified:
5 years, 8 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Fix locking for printing error messages." This reverts commit 187b3dfab5cca45e2af192bf7f5db09bcc156314. A unit test fails when it shouldn't. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4138 Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=85f1ffe2a98e4402cab7c3c00a752ea42197fa7b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -77 lines) Patch
M src/IceClFlags.h View 1 chunk +19 lines, -2 lines 0 comments Download
M src/IceClFlags.cpp View 1 chunk +0 lines, -37 lines 0 comments Download
M src/PNaClTranslator.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M unittest/BitcodeMunge.h View 3 chunks +1 line, -14 lines 0 comments Download
M unittest/BitcodeMunge.cpp View 1 chunk +6 lines, -12 lines 0 comments Download
M unittest/IceParseInstsTest.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Karl
Committed patchset #1 (id:1) manually as 85f1ffe2a98e4402cab7c3c00a752ea42197fa7b (presubmit successful).
5 years, 8 months ago (2015-04-16 22:11:11 UTC) #1
Karl
5 years, 8 months ago (2015-04-16 22:12:51 UTC) #3
jvoung (off chromium)
lgtm I didn't see an error, but I did see a warning: [WARNING] ../toolchain_build/src/llvm/utils/unittest/googletest/src/gtest-death-test.cc:791:: Death ...
5 years, 8 months ago (2015-04-16 22:25:42 UTC) #4
Karl
In my version of master, I'm now getting a core dump inside ErrorAt. I couldn't ...
5 years, 8 months ago (2015-04-16 22:27:33 UTC) #5
Karl
5 years, 8 months ago (2015-04-16 22:47:13 UTC) #6
Message was sent while issue was closed.
Relanding as https://codereview.chromium.org/1097563003.

Problem appears to be corrupt LLVM compile.

Powered by Google App Engine
This is Rietveld 408576698