Revert "Fix locking for printing error messages."

src/IceClFlags.h

Index: src/IceClFlags.h
diff --git a/src/IceClFlags.h b/src/IceClFlags.h
index c89e6959e62d9e30c2436b46f530c29486901bce..076200266b581fcc67132fe020222fb05df9d397 100644
--- a/src/IceClFlags.h
+++ b/src/IceClFlags.h
@@ -26,10 +26,27 @@ class ClFlags {
   ClFlags &operator=(const ClFlags &) = delete;
 
 public:
-  ClFlags() { resetClFlags(*this); }
+  ClFlags()
+      : // bool fields.
+        AllowErrorRecovery(false),
+        AllowUninitializedGlobals(false), DataSections(false),
+        DecorateAsm(false), DisableInternal(false), DisableIRGeneration(false),
+        DisableTranslation(false), DumpStats(false), FunctionSections(false),
+        GenerateUnitTestMessages(false), PhiEdgeSplit(false),
+        RandomNopInsertion(false), RandomRegAlloc(false),
+        SubzeroTimingEnabled(false), TimeEachFunction(false),
+        UseSandboxing(false),
+        // Enum and integer fields.
+        Opt(Opt_m1), OutFileType(FT_Iasm), RandomMaxNopsPerInstruction(0),
+        RandomNopProbabilityAsPercentage(0), TArch(TargetArch_NUM),
+        VMask(IceV_None),
+        // IceString fields.
+        DefaultFunctionPrefix(""), DefaultGlobalPrefix(""), TestPrefix(""),
+        TimingFocusOn(""), TranslateOnly(""), VerboseFocusOn(""),
+        // size_t and 64-bit fields.
+        NumTranslationThreads(0), RandomSeed(0) {}
 
   static void parseFlags(int argc, char *argv[]);
-  static void resetClFlags(ClFlags &OutFlags);
   static void getParsedClFlags(ClFlags &OutFlags);
   static void getParsedClFlagsExtra(ClFlagsExtra &OutFlagsExtra);