IOS distiller common code

IOS distiller common code

This change is the IOS counterpart to
https://codereview.chromium.org/1101993003/

Code that is used for generating HTML and JavaScript have been moved
to a superclass; this changes the IOS code to use that.

BUG=472797
Committed: https://crrev.com/b592a04d0472ceba2b783d17d1b0f360f0fe3b38
Cr-Commit-Position: refs/heads/master@{#330742}

[mdjones, 2015-05-05 18:41:02]

mdjones@chromium.org changed reviewers:
+ noyau@chromium.org

[noyau (Ping after 24h), 2015-05-20 13:58:43]

lgtm

https://codereview.chromium.org/1071413003/diff/20001/ios/chrome/browser/dom_...
File ios/chrome/browser/dom_distiller/distiller_viewer.h (right):

https://codereview.chromium.org/1071413003/diff/20001/ios/chrome/browser/dom_...
ios/chrome/browser/dom_distiller/distiller_viewer.h:39: std::string
getJsBuffer();
Should probably be GetJavaScriptBuffer() (Starts with a capital and use
JavaScript to be consistent with the previous method).

[mdjones, 2015-05-20 15:45:55]

https://codereview.chromium.org/1071413003/diff/20001/ios/chrome/browser/dom_...
File ios/chrome/browser/dom_distiller/distiller_viewer.h (right):

https://codereview.chromium.org/1071413003/diff/20001/ios/chrome/browser/dom_...
ios/chrome/browser/dom_distiller/distiller_viewer.h:39: std::string
getJsBuffer();
On 2015/05/20 13:58:43, noyau wrote:
> Should probably be GetJavaScriptBuffer() (Starts with a capital and use
> JavaScript to be consistent with the previous method).

Done.

[mdjones, 2015-05-20 15:46:02]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2015-05-20 15:46:02]

The patchset sent to the CQ was uploaded after l-g-t-m from noyau@chromium.org
Link to the patchset: https://codereview.chromium.org/1071413003/#ps40001
(title: "function name consistency")

[commit-bot: I haz the power, 2015-05-20 15:46:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1071413003/40001

[commit-bot: I haz the power, 2015-05-20 15:55:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-20 15:56:16]

Patchset 3 (id:??) landed as
https://crrev.com/b592a04d0472ceba2b783d17d1b0f360f0fe3b38
Cr-Commit-Position: refs/heads/master@{#330742}

[noyau (Ping after 24h), 2015-05-20 16:15:04]

On 2015/05/20 15:56:16, I haz the power (commit-bot) wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/b592a04d0472ceba2b783d17d1b0f360f0fe3b38
> Cr-Commit-Position: refs/heads/master@{#330742}

You changed the name of the method, which is an override, and didn't change the
superclass. How could that compile?

[noyau (Ping after 24h), 2015-05-20 16:33:52]

On 2015/05/20 16:15:04, noyau wrote:
> On 2015/05/20 15:56:16, I haz the power (commit-bot) wrote:
> > Patchset 3 (id:??) landed as
> > https://crrev.com/b592a04d0472ceba2b783d17d1b0f360f0fe3b38
> > Cr-Commit-Position: refs/heads/master@{#330742}
> 
> You changed the name of the method, which is an override, and didn't change
the
> superclass. How could that compile?

Hu. Sorry, wrong method. Ignore me.