Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: ios/chrome/browser/dom_distiller/distiller_viewer.cc

Issue 1071413003: IOS distiller common code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@superclass
Patch Set: function name consistency Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/chrome/browser/dom_distiller/distiller_viewer.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ios/chrome/browser/dom_distiller/distiller_viewer.h" 5 #include "ios/chrome/browser/dom_distiller/distiller_viewer.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "components/dom_distiller/core/distilled_page_prefs.h" 9 #include "components/dom_distiller/core/distilled_page_prefs.h"
10 #include "components/dom_distiller/core/dom_distiller_request_view_base.h"
10 #include "components/dom_distiller/core/dom_distiller_service.h" 11 #include "components/dom_distiller/core/dom_distiller_service.h"
11 #include "components/dom_distiller/core/proto/distilled_article.pb.h" 12 #include "components/dom_distiller/core/proto/distilled_article.pb.h"
12 #include "components/dom_distiller/core/task_tracker.h" 13 #include "components/dom_distiller/core/task_tracker.h"
13 #include "components/dom_distiller/core/viewer.h" 14 #include "components/dom_distiller/core/viewer.h"
14 #include "ios/chrome/browser/dom_distiller/dom_distiller_service_factory.h" 15 #include "ios/chrome/browser/dom_distiller/dom_distiller_service_factory.h"
15 #include "ios/public/provider/chrome/browser/browser_state/chrome_browser_state. h" 16 #include "ios/public/provider/chrome/browser/browser_state/chrome_browser_state. h"
16 #include "ui/gfx/geometry/size.h" 17 #include "ui/gfx/geometry/size.h"
17 18
18 namespace dom_distiller { 19 namespace dom_distiller {
19 20
21 namespace {
22
23 class IOSContentDataCallback : public DistillerDataCallback {
24 public:
25 IOSContentDataCallback(
26 const GURL& url,
27 const DistillerViewer::DistillationFinishedCallback& callback,
28 DistillerViewer* distiller_viewer_handle);
29 ~IOSContentDataCallback() override{};
30 void RunCallback(std::string& data) override;
31
32 private:
33 // Extra param needed by the callback specified below.
34 GURL url_;
35 // The callback to be run.
36 const DistillerViewer::DistillationFinishedCallback callback_;
37 // A handle to the DistillerViewer object.
38 DistillerViewer* distiller_viewer_handle_;
39 };
40
41 IOSContentDataCallback::IOSContentDataCallback(
42 const GURL& url,
43 const DistillerViewer::DistillationFinishedCallback& callback,
44 DistillerViewer* distiller_viewer_handle)
45 : url_(url),
46 callback_(callback),
47 distiller_viewer_handle_(distiller_viewer_handle) {
48 }
49
50 void IOSContentDataCallback::RunCallback(std::string& data) {
51 std::string htmlAndScript(data);
52 htmlAndScript += "<script>" +
53 distiller_viewer_handle_->GetJavaScriptBuffer() +
54 "</script>";
55
56 callback_.Run(url_, htmlAndScript);
57 }
58
59 } // namespace
60
20 DistillerViewer::DistillerViewer(ios::ChromeBrowserState* browser_state, 61 DistillerViewer::DistillerViewer(ios::ChromeBrowserState* browser_state,
21 const GURL& url, 62 const GURL& url,
22 const DistillationFinishedCallback& callback) 63 const DistillationFinishedCallback& callback)
23 : url_(url), 64 : DomDistillerRequestViewBase(
24 callback_(callback), 65 scoped_ptr<DistillerDataCallback>(
25 distilled_page_prefs_(new DistilledPagePrefs(browser_state->GetPrefs())) { 66 new IOSContentDataCallback(url, callback, this)).Pass(),
67 new DistilledPagePrefs(browser_state->GetPrefs())) {
26 DCHECK(browser_state); 68 DCHECK(browser_state);
27 DCHECK(url.is_valid()); 69 DCHECK(url.is_valid());
28 dom_distiller::DomDistillerService* distillerService = 70 dom_distiller::DomDistillerService* distillerService =
29 dom_distiller::DomDistillerServiceFactory::GetForBrowserState( 71 dom_distiller::DomDistillerServiceFactory::GetForBrowserState(
30 browser_state); 72 browser_state);
31 73
32 viewer_handle_ = distillerService->ViewUrl( 74 viewer_handle_ = distillerService->ViewUrl(
33 this, distillerService->CreateDefaultDistillerPage(gfx::Size()), url); 75 this, distillerService->CreateDefaultDistillerPage(gfx::Size()), url);
34 } 76 }
35 77
36 DistillerViewer::~DistillerViewer() { 78 DistillerViewer::~DistillerViewer() {
37 } 79 }
38 80
39 void DistillerViewer::OnArticleReady( 81 void DistillerViewer::SendJavaScript(const std::string& buffer) {
40 const DistilledArticleProto* article_proto) { 82 js_buffer_ += buffer;
41 const std::string html = viewer::GetUnsafeArticleTemplateHtml( 83 }
42 &article_proto->pages(0), distilled_page_prefs_->GetTheme(),
43 distilled_page_prefs_->GetFontFamily());
44 84
45 std::string content_js = viewer::GetUnsafeArticleContentJs(article_proto); 85 std::string DistillerViewer::GetJavaScriptBuffer() {
46 // TODO(noyau): This can be done better with changes to the 86 return js_buffer_;
47 // DistillationFinishedCallback. http://crbug.com/472805
48 std::string htmlAndScript(html);
49 htmlAndScript += "<script>" + content_js + "</script>";
50
51 callback_.Run(url_, htmlAndScript);
52
53 // No need to hold on to the ViewerHandle now that distillation is complete.
54 viewer_handle_.reset();
55 } 87 }
56 88
57 } // namespace dom_distiller 89 } // namespace dom_distiller
OLDNEW
« no previous file with comments | « ios/chrome/browser/dom_distiller/distiller_viewer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698