fuse List and js Array together and a few other misc fixes.

fuse List and js Array together and a few other misc fixes.

BUG=
R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/9027fd9cd4f86b756af3337ab3ff1df0e12660a0

[Jacob, 2015-04-22 21:00:37]

jacobr@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2015-04-22 21:14:19]

https://codereview.chromium.org/1071393007/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1071393007/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:356: JS.Statement
_finishClassDef(ParameterizedType type, JS.Statement body, String jsPeerName) {
long line?

https://codereview.chromium.org/1071393007/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:416:
classDefs.add(js.statement('dart.copyProperties(window.#.prototype,
#.prototype);', [
`window` seems dubious :)

a few other ideas:
1. capture up front into temp, e.g. `let JsString = String;`
2. rename our type locally: `class DartString { ... }`
3. save the JS type in dart_runtime.js and use: `dart.JsString` ... we already
do this for Symbol

https://codereview.chromium.org/1071393007/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:418: name])); // XXX Array-->VAL;
remove?

https://codereview.chromium.org/1071393007/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:2348: return new JS.Identifier(extName);
ah, nice fix.

https://codereview.chromium.org/1071393007/diff/1/tool/input_sdk/patch/core_p...
File tool/input_sdk/patch/core_patch.dart (left):

https://codereview.chromium.org/1071393007/diff/1/tool/input_sdk/patch/core_p...
tool/input_sdk/patch/core_patch.dart:245: factory List([int length = const
_ListConstructorSentinel()]) {
wow, craziness

https://codereview.chromium.org/1071393007/diff/1/tool/input_sdk/patch/core_p...
File tool/input_sdk/patch/core_patch.dart (right):

https://codereview.chromium.org/1071393007/diff/1/tool/input_sdk/patch/core_p...
tool/input_sdk/patch/core_patch.dart:255: JS('void', r'#.fixed$length = Array',
list);
maybe TODO to revisit this? e.g. TODO(jmesserly): consider a fixed array
subclass instead

https://codereview.chromium.org/1071393007/diff/1/tool/input_sdk/private/js_h...
File tool/input_sdk/private/js_helper.dart (right):

https://codereview.chromium.org/1071393007/diff/1/tool/input_sdk/private/js_h...
tool/input_sdk/private/js_helper.dart:687: static constructorNameFallback =
JS('Function', r'''
TODO:remove?

https://codereview.chromium.org/1071393007/diff/1/tool/input_sdk/private/js_h...
tool/input_sdk/private/js_helper.dart:745: // codeUnitAt is not yet supported.
ideally we kill the entire method :)

[Jacob, 2015-04-22 22:58:32]

ptal

https://codereview.chromium.org/1071393007/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1071393007/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:356: JS.Statement
_finishClassDef(ParameterizedType type, JS.Statement body, String jsPeerName) {
On 2015/04/22 21:14:18, John Messerly wrote:
> long line?

Done.

https://codereview.chromium.org/1071393007/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:416:
classDefs.add(js.statement('dart.copyProperties(window.#.prototype,
#.prototype);', [
On 2015/04/22 21:14:18, John Messerly wrote:
> `window` seems dubious :)
> 
> a few other ideas:
> 1. capture up front into temp, e.g. `let JsString = String;`
> 2. rename our type locally: `class DartString { ... }`
> 3. save the JS type in dart_runtime.js and use: `dart.JsString` ... we already
> do this for Symbol

done.
added
dart.global = window || global;
to work with node and web.

https://codereview.chromium.org/1071393007/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:418: name])); // XXX Array-->VAL;
On 2015/04/22 21:14:18, John Messerly wrote:
> remove?

removed. any XXX comments will be removed before commit.

https://codereview.chromium.org/1071393007/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:2348: return new JS.Identifier(extName);
On 2015/04/22 21:14:18, John Messerly wrote:
> ah, nice fix.

Acknowledged.

https://codereview.chromium.org/1071393007/diff/1/tool/input_sdk/patch/core_p...
File tool/input_sdk/patch/core_patch.dart (left):

https://codereview.chromium.org/1071393007/diff/1/tool/input_sdk/patch/core_p...
tool/input_sdk/patch/core_patch.dart:245: factory List([int length = const
_ListConstructorSentinel()]) {
On 2015/04/22 21:14:19, John Messerly wrote:
> wow, craziness
yep. this just in... 
new List() should fail checked mode on dart2js. :)

https://codereview.chromium.org/1071393007/diff/1/tool/input_sdk/patch/core_p...
File tool/input_sdk/patch/core_patch.dart (right):

https://codereview.chromium.org/1071393007/diff/1/tool/input_sdk/patch/core_p...
tool/input_sdk/patch/core_patch.dart:255: JS('void', r'#.fixed$length = Array',
list);
On 2015/04/22 21:14:19, John Messerly wrote:
> maybe TODO to revisit this? e.g. TODO(jmesserly): consider a fixed array
> subclass instead

Done. I like adding TODO(jmesserly) better than TODO(jacobr)

https://codereview.chromium.org/1071393007/diff/1/tool/input_sdk/private/js_h...
File tool/input_sdk/private/js_helper.dart (right):

https://codereview.chromium.org/1071393007/diff/1/tool/input_sdk/private/js_h...
tool/input_sdk/private/js_helper.dart:687: static constructorNameFallback =
JS('Function', r'''
On 2015/04/22 21:14:19, John Messerly wrote:
> TODO:remove?

agreed. done

https://codereview.chromium.org/1071393007/diff/1/tool/input_sdk/private/js_h...
tool/input_sdk/private/js_helper.dart:745: // codeUnitAt is not yet supported.
On 2015/04/22 21:14:19, John Messerly wrote:
> ideally we kill the entire method :)

yeah.  this method is pretty crazy but copying it was easier than researching
what the technically correct thing to do in ES6 would be.

[Jennifer Messerly, 2015-04-23 00:14:39]

lgtm

[Jacob, 2015-04-23 00:23:38]

Committed patchset #3 (id:40001) manually as
9027fd9cd4f86b756af3337ab3ff1df0e12660a0 (presubmit successful).