fuse List and js Array together and a few other misc fixes.

tool/input_sdk/private/js_helper.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library _js_helper;
 
 import 'dart:_js_embedded_names' show
     ALL_CLASSES,
     GET_ISOLATE_TAG,
     INTERCEPTED_NAMES,
@@ skipping 44 matching lines @@
     JS_SIGNATURE_NAME,
     JS_STRING_CONCAT,
     RAW_DART_FUNCTION_REF;
 
 import 'dart:_interceptors';
 import 'dart:_internal' as _symbol_dev;
 import 'dart:_internal' show MappedIterable;
 
 import 'dart:_js_names' show
     extractKeys,
-    mangledNames,
-    unmangleGlobalNameIfPreservedAnyways,
-    unmangleAllIdentifiersIfPreservedAnyways;
+    mangledNames;
 
 part 'annotations.dart';
 part 'constant_map.dart';
 part 'native_helper.dart';
 part 'regexp_helper.dart';
 part 'string_helper.dart';
 part 'js_rti.dart';
 
+// TODO(jacobr): remove.
+String unmangleGlobalNameIfPreservedAnyways(String str) => str;
+// TODO(jacobr): remove.
+String unmangleAllIdentifiersIfPreservedAnyways(String str) => str;
+
 class _Patch {
   const _Patch();
 }
 
 const _Patch patch = const _Patch();
 
 
 /// Marks the internal map in dart2js, so that internal libraries can is-check
 // them.
 abstract class InternalMap {
@@ skipping 588 matching lines @@
         return result;
       }
       return handleError(source);
     }
     return result;
   }
 
   /** [: r"$".codeUnitAt(0) :] */
   static const int DOLLAR_CHAR_VALUE = 36;
 
+  static constructorNameFallback = JS('Function', r'''

[Jennifer Messerly, 2015/04/22 21:14:19]

TODO:remove?

[Jacob, 2015/04/22 22:58:32]

agreed. done

+  function getTagFallback(o) {
+    var constructor = o.constructor;
+    if (typeof constructor == "function") {
+      var name = constructor.name;
+      // If the name is a non-empty string, we use that as the type name of this
+      // object.  There are various cases where that does not work, so we have to
+      // detect them and fall through to the toString() based implementation.
+
+      if (typeof name == "string" &&
+
+          // Sometimes the string is empty.  This test also catches minified
+          // shadow dom polyfil wrapper for Window on Firefox where the faked
+          // constructor name does not 'stick'.  The shortest real DOM object
+          // names have three characters (e.g. URL, CSS).
+          name.length > 2 &&
+
+          // On Firefox we often get "Object" as the constructor name, even for
+          // more specialized DOM objects.
+          name !== "Object" &&
+
+          // This can happen in Opera.
+          name !== "Function.prototype") {
+        return name;
+      }
+    }
+    var s = Object.prototype.toString.call(o);
+    return s.substring(8, s.length - 1);
+  }''');
+
   /// Creates a string containing the complete type for the class [className]
   /// with the given type arguments.
   ///
   /// In minified mode, uses the unminified names if available.
   static String formatType(String className, List typeArguments) {
     return unmangleAllIdentifiersIfPreservedAnyways
         ('$className${joinArguments(typeArguments, 0)}');
   }
 
   /// Returns the type of [object] as a string (including type arguments).
   ///
   /// In minified mode, uses the unminified names if available.
   static String objectTypeName(Object object) {
-    String name = constructorNameFallback(getInterceptor(object));
+    String name = JS('String', '#(#)', constructorNameFallback, object);
     if (name == 'Object') {
       // Try to decompile the constructor by turning it into a string and get
       // the name out of that. If the decompiled name is a string containing an
       // identifier, we use that instead of the very generic 'Object'.
       var decompiled =
           JS('var', r'#.match(/^\s*function\s*(\S*)\s*\(/)[1]',
               JS('var', r'String(#.constructor)', object));
       if (decompiled is String)
         if (JS('bool', r'/^\w+$/.test(#)', decompiled))
           name = decompiled;
     }
     // TODO(kasperl): If the namer gave us a fresh global name, we may
     // want to remove the numeric suffix that makes it unique too.
+    // TODO(jacobr): commented this out as it seems bogus and it breaks as
+    // codeUnitAt is not yet supported.

[Jennifer Messerly, 2015/04/22 21:14:19]

ideally we kill the entire method :)

[Jacob, 2015/04/22 22:58:32]

yeah.  this method is pretty crazy but copying it was easier than researching
what the technically correct thing to do in ES6 would be.

+    /*
     if (name.length > 1 && identical(name.codeUnitAt(0), DOLLAR_CHAR_VALUE)) {
       name = name.substring(1);
     }
+    */
     return formatType(name, getRuntimeTypeInfo(object));
   }
 
   /// In minified mode, uses the unminified names if available.
   static String objectToString(Object object) {
     String name = objectTypeName(object);
     return "Instance of '$name'";
   }
 
   static num dateNow() => JS('int', r'Date.now()');
@@ skipping 2708 matching lines @@
   throw new MainError("No top-level function named 'main'.");
 }
 
 void badMain() {
   throw new MainError("'main' is not a function.");
 }
 
 void mainHasTooManyParameters() {
   throw new MainError("'main' expects too many parameters.");
 }