Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 1071333002: Added ability to flush context to GrTextBlobCache (Closed)

Created:
5 years, 8 months ago by joshua.litt
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

The TextBlobCache needs the ability to trigger a flush because otherwise its entire budget can be used up, but it will not be able to free up any space due to blobs being stuck in the GrInOrderDrawBuffer. This was causing a segfault. After this CL the cache will try to purge, and then flush if it cannot purge enough. It will not purge the most recent addition to the cache. TBR=bsalomon@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/0db6dfaeb2d1376ad393516fb22af7ecf62718fa

Patch Set 1 #

Patch Set 2 : fix cache budget #

Total comments: 2

Patch Set 3 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -6 lines) Patch
M include/gpu/GrContext.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 2 chunks +12 lines, -1 line 0 comments Download
M src/gpu/GrTextBlobCache.h View 1 2 3 chunks +31 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
joshualitt
ptal
5 years, 8 months ago (2015-04-09 21:44:58 UTC) #2
robertphillips
lgtm + nits. Could you expand the CL description to include what's going on/why this ...
5 years, 8 months ago (2015-04-10 12:22:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071333002/40001
5 years, 8 months ago (2015-04-10 13:19:09 UTC) #6
commit-bot: I haz the power
Presubmit check for 1071333002-40001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-10 13:19:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071333002/40001
5 years, 8 months ago (2015-04-10 13:53:55 UTC) #12
commit-bot: I haz the power
Presubmit check for 1071333002-40001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-10 13:54:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071333002/40001
5 years, 8 months ago (2015-04-10 13:54:21 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 14:01:34 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/0db6dfaeb2d1376ad393516fb22af7ecf62718fa

Powered by Google App Engine
This is Rietveld 408576698