Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: content/renderer/service_worker/service_worker_script_context.cc

Issue 1071203002: Consistently handle persistent notification ids as int64_t (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-db-Integrate
Patch Set: rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/service_worker/service_worker_script_context.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/service_worker/service_worker_script_context.cc
diff --git a/content/renderer/service_worker/service_worker_script_context.cc b/content/renderer/service_worker/service_worker_script_context.cc
index 372052057edb716f5836a9de5efa5fc8541ef5e1..de32db8ddc38c986363fbf03a1d28e4c4e16b48f 100644
--- a/content/renderer/service_worker/service_worker_script_context.cc
+++ b/content/renderer/service_worker/service_worker_script_context.cc
@@ -365,14 +365,14 @@ void ServiceWorkerScriptContext::OnSyncEvent(int request_id) {
void ServiceWorkerScriptContext::OnNotificationClickEvent(
int request_id,
- const std::string& notification_id,
+ int64_t persistent_notification_id,
const PlatformNotificationData& notification_data) {
TRACE_EVENT0("ServiceWorker",
"ServiceWorkerScriptContext::OnNotificationClickEvent");
notification_click_start_timings_[request_id] = base::TimeTicks::Now();
proxy_->dispatchNotificationClickEvent(
request_id,
- blink::WebString::fromUTF8(notification_id),
+ persistent_notification_id,
ToWebNotificationData(notification_data));
}
« no previous file with comments | « content/renderer/service_worker/service_worker_script_context.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698