content/renderer/service_worker/service_worker_script_context.h - Issue 1071203002: Consistently handle persistent notification ids as int64_t

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/service_worker_script_context.h

Issue 1071203002: Consistently handle persistent notification ids as int64_t (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-db-Integrate

Patch Set: rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/service_worker/service_worker_messages.h ('k') | content/renderer/service_worker/service_worker_script_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/service_worker_script_context.h

diff --git a/content/renderer/service_worker/service_worker_script_context.h b/content/renderer/service_worker/service_worker_script_context.h

index 2def78fe69c174cad90aa71b2ddd861c04554c60..f0c82585d388c0f5829bf416150a6a042aca0b23 100644

--- a/content/renderer/service_worker/service_worker_script_context.h

+++ b/content/renderer/service_worker/service_worker_script_context.h

@@ -115,7 +115,7 @@ class ServiceWorkerScriptContext {

void OnSyncEvent(int request_id);

void OnNotificationClickEvent(

int request_id,

- const std::string& notification_id,

+ int64_t persistent_notification_id,

const PlatformNotificationData& notification_data);

void OnPushEvent(int request_id, const std::string& data);

void OnGeofencingEvent(int request_id,