Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1071203002: Consistently handle persistent notification ids as int64_t (Closed)

Created:
5 years, 8 months ago by Peter Beverloo
Modified:
5 years, 8 months ago
Reviewers:
johnme, michaeln, Mike West
CC:
chromium-reviews, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-notifications_chromium.org, mlamouri+watch-content_chromium.org, nhiroki, peter+watch_chromium.org, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@n-db-Integrate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consistently handle persistent notification ids as int64_t This changes the renderer side of Chromium to only denote persistent notification ids as int64_ts rather than as strings. This CL is part of a three-sided patch: [1] https://codereview.chromium.org/1078783002/ [2] This CL. [3] https://codereview.chromium.org/1072873002/ BUG= Committed: https://crrev.com/f08addc1cd8b71b8e60c6b33838ff4d02c62a9a1 Cr-Commit-Position: refs/heads/master@{#325469}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -45 lines) Patch
M content/browser/notifications/notification_event_dispatcher_impl.cc View 1 2 chunks +1 line, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 1 chunk +9 lines, -11 lines 0 comments Download
M content/child/notifications/notification_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/notifications/notification_manager.cc View 1 6 chunks +5 lines, -20 lines 0 comments Download
M content/common/platform_notification_messages.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/service_worker/service_worker_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_script_context.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_script_context.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Peter Beverloo
+johnme for notifications +mkwst for IPC +michaeln for service_worker stamp (string -> int64)
5 years, 8 months ago (2015-04-09 16:19:49 UTC) #2
michaeln
r/s lgtm
5 years, 8 months ago (2015-04-10 00:00:10 UTC) #3
Mike West
IPC LGTM.
5 years, 8 months ago (2015-04-10 11:13:10 UTC) #4
johnme
notifications lgtm
5 years, 8 months ago (2015-04-10 11:13:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071203002/20001
5 years, 8 months ago (2015-04-16 14:36:28 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-16 17:37:51 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 17:38:36 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f08addc1cd8b71b8e60c6b33838ff4d02c62a9a1
Cr-Commit-Position: refs/heads/master@{#325469}

Powered by Google App Engine
This is Rietveld 408576698