Change device IDs from unsigned to signed.

Change device IDs from unsigned to signed.

Change ui::InputDevice::id and ash::DisplayInfo::touch_device_id_ from
'unsigned int' to 'int' in accordance with the coding style guide.

Committed: https://crrev.com/a824971547acc92c86a302e442c385f94d63a3fb
Cr-Commit-Position: refs/heads/master@{#325042}

[kpschoedel, 2015-04-09 16:06:24]

kpschoedel@chromium.org changed reviewers:
+ derat@chromium.org, sadrul@chromium.org

[kpschoedel, 2015-04-09 16:07:07]

Split from https://codereview.chromium.org/1073573002/

[kpschoedel, 2015-04-09 16:07:22]

The CQ bit was checked by kpschoedel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-09 16:08:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1071193002/1

[commit-bot: I haz the power, 2015-04-09 16:19:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-09 16:19:22]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Daniel Erat, 2015-04-09 16:41:21]

https://codereview.chromium.org/1071193002/diff/1/ui/events/devices/x11/touch...
File ui/events/devices/x11/touch_factory_x11.cc (right):

https://codereview.chromium.org/1071193002/diff/1/ui/events/devices/x11/touch...
ui/events/devices/x11/touch_factory_x11.cc:239: return (deviceid > 0 &&
should this be >= instead of >? if the difference from the other checks is
intentional, this deserves a comment.

[kpschoedel, 2015-04-09 17:27:51]

https://codereview.chromium.org/1071193002/diff/1/ui/events/devices/x11/touch...
File ui/events/devices/x11/touch_factory_x11.cc (right):

https://codereview.chromium.org/1071193002/diff/1/ui/events/devices/x11/touch...
ui/events/devices/x11/touch_factory_x11.cc:239: return (deviceid > 0 &&
On 2015/04/09 16:41:21, Daniel Erat wrote:
> should this be >= instead of >? if the difference from the other checks is
> intentional, this deserves a comment.

Done.

[Daniel Erat, 2015-04-09 19:55:27]

lgtm with one suggestion, but sadrul probably needs to approve

https://codereview.chromium.org/1071193002/diff/40001/ui/events/devices/x11/t...
File ui/events/devices/x11/touch_factory_x11.cc (right):

https://codereview.chromium.org/1071193002/diff/40001/ui/events/devices/x11/t...
ui/events/devices/x11/touch_factory_x11.cc:225: (static_cast<size_t>(*iter) <
touch_device_lookup_.size()));
one more comment: since this is duplicated a few times and sort of long and
ugly, it'd probably be worthwhile moving it into a private helper method, e.g.:

  bool DeviceIdIsValid(int id) const {
    return id >= 0 && static_cast<size_t>(id) < touch_device_lookup_.size();
  }

[kpschoedel, 2015-04-09 20:12:32]

https://codereview.chromium.org/1071193002/diff/40001/ui/events/devices/x11/t...
File ui/events/devices/x11/touch_factory_x11.cc (right):

https://codereview.chromium.org/1071193002/diff/40001/ui/events/devices/x11/t...
ui/events/devices/x11/touch_factory_x11.cc:225: (static_cast<size_t>(*iter) <
touch_device_lookup_.size()));
On 2015/04/09 19:55:27, Daniel Erat wrote:
> one more comment: since this is duplicated a few times and sort of long and
> ugly, it'd probably be worthwhile moving it into a private helper method,
e.g.:
> 
>   bool DeviceIdIsValid(int id) const {
>     return id >= 0 && static_cast<size_t>(id) < touch_device_lookup_.size();
>   }

Done.

[sadrul, 2015-04-09 20:19:19]

lgtm

[kpschoedel, 2015-04-09 20:22:06]

The CQ bit was checked by kpschoedel@chromium.org

[kpschoedel, 2015-04-09 20:22:07]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org
Link to the patchset: https://codereview.chromium.org/1071193002/#ps60001
(title: "address review comments (derat@)")

[commit-bot: I haz the power, 2015-04-09 20:22:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1071193002/60001

[kpschoedel, 2015-04-09 22:22:22]

The CQ bit was unchecked by kpschoedel@chromium.org

[kpschoedel, 2015-04-13 22:31:03]

The CQ bit was checked by kpschoedel@chromium.org to run a CQ dry run

[kpschoedel, 2015-04-13 22:31:04]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org,
derat@chromium.org
Link to the patchset: https://codereview.chromium.org/1071193002/#ps80001
(title: "check for negative IDs")

[commit-bot: I haz the power, 2015-04-13 22:35:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1071193002/80001

[commit-bot: I haz the power, 2015-04-14 00:34:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-14 00:34:03]

This issue passed the CQ dry run.

[kpschoedel, 2015-04-14 14:35:13]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2015-04-14 14:35:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1071193002/80001

[commit-bot: I haz the power, 2015-04-14 14:36:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-14 14:37:16]

Patchset 5 (id:??) landed as
https://crrev.com/a824971547acc92c86a302e442c385f94d63a3fb
Cr-Commit-Position: refs/heads/master@{#325042}